508243 - Move CC* release automation classes to buildbotcustom

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Robert Kaiser]

This is the last step to have release automation for comm-central, the CC* classes I have prototyped in ccfactory.py in SeaMonkey's buildbot config need to be moved to buildbotcustom.

Comment 1

[Robert Kaiser]

Attachment: Add CC release classes to factory.py

Here's the patch that adds all the classes we need changed to factory.py - all the others, like updates or the verification classes, can just be used directly.

The source class is different enough that deriving from the Firefox one doesn't make much sense, but the rest are derived from the common ones as usual.

Those are exactly the classes I used for the SeaMonkey 2.0b1 release.

Comment 2

[Philippe M. Chiasson (:gozer)]

Comment on attachment 392476 [details] [diff] [review]
Add CC release classes to factory.py

in CCReleaseRepackFactory.updateSources(), shouldn't it use client.py instead of updating/pulling stuff directly ?

In, CCSourceFactory, should it call 'make source-package' instead of tarring up things by itself ?

Comment 3

[[e-mail] (:bhearsum)]

Comment on attachment 392476 [details] [diff] [review]
Add CC release classes to factory.py

>+class CCReleaseBuildFactory(CCMercurialBuildFactory, ReleaseBuildFactory):
>+    def __init__(self, mozRepoPath='', inspectorRepoPath='',
>+                 venkmanRepoPath='', cvsroot='', **kwargs):
>+        self.skipBlankRepos = True
>+        self.mozRepoPath = mozRepoPath
>+        self.inspectorRepoPath = inspectorRepoPath
>+        self.venkmanRepoPath = venkmanRepoPath
>+        self.cvsroot = cvsroot
>+        ReleaseBuildFactory.__init__(self, mozillaDir='mozilla', **kwargs)
>+
> 

/me is happy that this is all you need to do here.


>+class CCReleaseTaggingFactory(ReleaseTaggingFactory):
>+    def __init__(self, chatzillaTimestamp, cvsroot, **kwargs):
>+        ReleaseTaggingFactory.__init__(self, **kwargs)
>+
>+        # need to repeat those definitions here
>+        buildTag = '%s_BUILD%s' % (kwargs['baseTag'], str(kwargs['buildNumber']))
>+        releaseTag = '%s_RELEASE' % kwargs['baseTag']
>+
You're totally welcome to set these in ReleaseTaggingFactory.__init__ rather than regenerating them here.


Looks fine otherwise.

Comment 4

[Robert Kaiser]

(In reply to comment #2)
> (From update of attachment 392476 [details] [diff] [review])
> in CCReleaseRepackFactory.updateSources(), shouldn't it use client.py instead
> of updating/pulling stuff directly ?

It actually pulls with client.py but then makes sure we have the right revision by directly doing a hg up (note that we don't pull, just update). I'm following what the main ReleaseRepackFactory does there and it's no harm to do another update to be sure.

> In, CCSourceFactory, should it call 'make source-package' instead of tarring up
> things by itself ?

I think we should end up doing that one day, yes, but we need to prepare the build environment to use that and I wasn't in the mood to figure that out so I just did what matches the source factory the original has.

Comment 5

[Robert Kaiser]

Attachment: Add CC release classes to factory.py, v1.1

Here's an updated version that doesn't redefine buildTag and releaseTag.
Ben, I'm re-requesting your review for making sure I haven't missed any "self." in there.
Gozer, is it OK to take them this way with my comments above and possibly improve them later on?

Comment 6

[Philippe M. Chiasson (:gozer)]

(In reply to comment #5)
> Created an attachment (id=393826) [details]
> Add CC release classes to factory.py, v1.1
> 
> [...]
> Gozer, is it OK to take them this way with my comments above and possibly
> improve them later on?

Yes, that's fine by me.

Comment 7

[[e-mail] (:bhearsum)]

Comment on attachment 393826 [details] [diff] [review]
Add CC release classes to factory.py, v1.1

Looks good to me!

Comment 8

[Robert Kaiser]

Pushed as http://hg.mozilla.org/build/buildbotcustom/rev/af77957a3b08 and filed bug 510770 for 'make source-package' as mentioned by gozer in comment #2 - it affects both SingleSourceFactory and CCSourceFactory in any case.