508274 - comm-central build redness after bug 476208

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Robert Kaiser]

I updated buildbotcustom to a changeset after bug 476208 today, and noticed that all builds went red with messages like this one:

buildid: "python: can't open file 'build/config/printconfigsetting.py': [Errno 2] No such file or directory"

The problem is that the added printconfigsetting.py calls don't take the mozilla subdir(s) in the comm-central configuration into account. I'll test a patch in a moment and attach it if it works well.

Comment 1

[Robert Kaiser]

Attachment: Make sure to look into mozilla dirs where needed

This patch uses the variables we have to make sure we look into the mozilla dirs where needed, for non-comm-central this refers to the same as before, but for SeaMonkey and Thunderbird, we find the right files with this patch as well.

Comment 2

[[e-mail] (:bhearsum)]

Comment on attachment 392505 [details] [diff] [review]
Make sure to look into mozilla dirs where needed

Yep, looks good. Let me know when you land it so I can update our master, please.

Comment 3

[Robert Kaiser]

Pushed as http://hg.mozilla.org/build/buildbotcustom/rev/2f8dcfefe2ab

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Did you really mean
+          command=['python', 'build%s/config/printconfigsetting.py' % self.mozillaDir,
and not 
+          command=['python', 'build/%s/config/printconfigsetting.py' % self.mozillaDir,

Comment 5

[Robert Kaiser]

(In reply to comment #4)
> Did you really mean
> +          command=['python', 'build%s/config/printconfigsetting.py' %
> self.mozillaDir,
> and not 
> +          command=['python', 'build/%s/config/printconfigsetting.py' %
> self.mozillaDir,

Yes. self.mozillaDir == '' for Firefox etc. and self.mozillaDir == '/mozilla' for comm-central builds (SeaMonkey, Thunderbird) in this factory.