508280 - Merge strres.js code into Venkman's utils.js

Status: RESOLVED FIXED

(Other Applications Graveyard :: Venkman JS Debugger, defect)

Description

[Serge Gautherie (:sgautherie)]

/mozilla/extensions/venkman/resources/content/venkman-scripts.xul
    * line 63 -- <script src="chrome://global/content/strres.js"/>

/mozilla/extensions/venkman-cvs/resources/content/venkman-scripts.xul
    * line 62 -- <script src="chrome://global/content/strres.js"/>

*****

What is venkman-cvs? And why is it linked from comm-central?

Comment 1

[:Gijs (he/him)]

We need the same fix here as in ChatZilla, ie copy it to utils.js

(In reply to comment #0)
> What is venkman-cvs? And why is it linked from comm-central?

I believe it's the backup of whatever was imported before venkman switched to hg. If it's actually in the repo, that'd be a bug, but it'd have to do with the scripts that deal with that stuff, not with Venkman itself, and it is definitely not related to this bug.

Comment 2

[Serge Gautherie (:sgautherie)]

(In reply to comment #1)
> (In reply to comment #0)
> > What is venkman-cvs? And why is it linked from comm-central?
> 
> I believe it's the backup of whatever was imported before venkman switched to
> hg. If it's actually in the repo, that'd be a bug

Ah, right, forgot about that: filed bug 508392.

Comment 3

[:Gijs (he/him)]

Attachment: Patch

Comment 4

[Karsten Düsterloh]

Comment on attachment 409723 [details] [diff] [review]
Patch

Is it really worth keeping this function at all? The only consumer is initStringBundle in venkman-msg.js, which might as well just do it itself...

Comment 5

[:Gijs (he/him)]

Attachment: Better patch

That's a good point. This is probably better. Tested, works. Hurray for code removal!

Comment 6

[:Gijs (he/him)]

http://hg.mozilla.org/venkman/rev/51baabbbef37

Comment 7

[Serge Gautherie (:sgautherie)]

Sorry, wrong bug.