Closed
Bug 508397
Opened 17 years ago
Closed 17 years ago
Cleanup nsToolkit
Categories
(Core Graveyard :: Widget: OS/2, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: robarnold, Assigned: robarnold)
References
Details
Attachments
(1 file, 1 obsolete file)
|
22.39 KB,
patch
|
Details | Diff | Splinter Review |
Spin off of bug 503877 for OS/2. With the removal of the nsSwitchToUIThread code, there is not much left in nsToolkit for OS/2. Since these changes are much more drastic than bug 503877, a separate bug seemed appropriate.
The attached patch cleans up most of nsToolkit.
A further optimization would be to get rid of the TLS index access however bug 503879 will likely eliminate nsToolkit (this patch will simplify that work).
Attachment #392596 -
Flags: review?(mozilla)
Comment 1•17 years ago
|
||
Comment on attachment 392596 [details] [diff] [review]
v1.0
> class nsWindow : public nsBaseWidget,
>- public nsSwitchToUIThread
Remove the trailing comma, too.
>- // nsSwitchToPMThread interface
>- virtual BOOL CallMethod(MethodInfo *info);
You removed the function declaration from nsWindow.h but the function itself in nsWindow.cpp needs to go, too.
Otherwise I don't see any problems. Great to see this code go. :-)
Attachment #392596 -
Flags: review?(mozilla) → review+
| Assignee | ||
Comment 2•17 years ago
|
||
Updated version
| Assignee | ||
Comment 3•17 years ago
|
||
Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/12720ff0aaec
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•