Closed Bug 508397 Opened 17 years ago Closed 17 years ago

Cleanup nsToolkit

Categories

(Core Graveyard :: Widget: OS/2, defect)

x86
OS/2
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: robarnold, Assigned: robarnold)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch v1.0 (obsolete) — — Splinter Review
Spin off of bug 503877 for OS/2. With the removal of the nsSwitchToUIThread code, there is not much left in nsToolkit for OS/2. Since these changes are much more drastic than bug 503877, a separate bug seemed appropriate. The attached patch cleans up most of nsToolkit. A further optimization would be to get rid of the TLS index access however bug 503879 will likely eliminate nsToolkit (this patch will simplify that work).
Attachment #392596 - Flags: review?(mozilla)
Comment on attachment 392596 [details] [diff] [review] v1.0 > class nsWindow : public nsBaseWidget, >- public nsSwitchToUIThread Remove the trailing comma, too. >- // nsSwitchToPMThread interface >- virtual BOOL CallMethod(MethodInfo *info); You removed the function declaration from nsWindow.h but the function itself in nsWindow.cpp needs to go, too. Otherwise I don't see any problems. Great to see this code go. :-)
Attachment #392596 - Flags: review?(mozilla) → review+
Attached patch v1.1 — — Splinter Review
Updated version
Assignee: mozilla → tellrob
Attachment #392596 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: