508397 - Cleanup nsToolkit

Status: RESOLVED FIXED

(Core Graveyard :: Widget: OS/2, defect)

Description

[Rob Arnold [:robarnold]]

Attachment: v1.0

Spin off of bug 503877 for OS/2. With the removal of the nsSwitchToUIThread code, there is not much left in nsToolkit for OS/2. Since these changes are much more drastic than bug 503877, a separate bug seemed appropriate.

The attached patch cleans up most of nsToolkit.

A further optimization would be to get rid of the TLS index access however bug 503879 will likely eliminate nsToolkit (this patch will simplify that work).

Comment 1

[Peter Weilbacher]

Comment on attachment 392596 [details] [diff] [review]
v1.0

> class nsWindow : public nsBaseWidget,
>-                 public nsSwitchToUIThread

Remove the trailing comma, too.

>-   // nsSwitchToPMThread interface
>-   virtual BOOL CallMethod(MethodInfo *info);

You removed the function declaration from nsWindow.h but the function itself in nsWindow.cpp needs to go, too.

Otherwise I don't see any problems. Great to see this code go. :-)

Comment 2

[Rob Arnold [:robarnold]]

Attachment: v1.1

Updated version

Comment 3

[Rob Arnold [:robarnold]]

Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/12720ff0aaec