The default bug view has changed. See this FAQ.

update to current spec for canvas ctx.font getter and setter

RESOLVED FIXED in mozilla2.0b3

Status

()

Core
Canvas: 2D
P2
normal
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

Trunk
mozilla2.0b3
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Assignee)

Description

8 years ago
Hixie recently made some changes to the spec for the ctx.font getter and setter; I have a work in progress patch to implement them at http://hg.mozilla.org/users/dbaron_mozilla.com/patches/file/tip/ctx-font-updates but I still need to write tests (and make sure the patch passes them).
(Assignee)

Comment 1

8 years ago
I realize my current patch doesn't work for system fonts, though.

Comment 2

8 years ago
Is there a reference to a spec?
(Assignee)

Comment 3

8 years ago
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#text
(Assignee)

Comment 4

8 years ago
I also wonder if I should be editing our canvas tests directly or if there's a source form for them that's not in our tree that I should be editing instead.
(Assignee)

Comment 5

7 years ago
http://philip.html5.org/tests/canvas/suite/tests/ may be the source of the tests; I need to investigate further to see if there's something there that puts them in the form we have.
(Assignee)

Comment 6

7 years ago
Created attachment 452494 [details] [diff] [review]
revert (and merge to tip) incorrect changes from bug 523496
Attachment #452494 - Flags: review?(bzbarsky)
(Assignee)

Comment 7

7 years ago
Created attachment 452495 [details] [diff] [review]
patch 2: remove redundant parsing of line-height

Parsing the 'font' shorthand is sufficient.
Attachment #452495 - Flags: review?(bzbarsky)
(Assignee)

Comment 8

7 years ago
Created attachment 452496 [details] [diff] [review]
patch 3: implement the spec updates

... though, honestly, I'm a little skeptical, because each time I think about posting this patch, it turns out that the spec has changed again.
Attachment #452496 - Flags: review?(bzbarsky)
(Assignee)

Updated

7 years ago
Attachment #452495 - Flags: review?(bzbarsky)
(Assignee)

Comment 9

7 years ago
Comment on attachment 452496 [details] [diff] [review]
patch 3: implement the spec updates

Actually, I changed my mind; I can simplify this code a bit now that the requirements changed again.
Attachment #452496 - Flags: review?(bzbarsky)
(Assignee)

Comment 10

7 years ago
Created attachment 452499 [details] [diff] [review]
implement the spec updates

Simpler version.
Attachment #452495 - Attachment is obsolete: true
Attachment #452496 - Attachment is obsolete: true
Attachment #452499 - Flags: review?(bzbarsky)
Comment on attachment 452494 [details] [diff] [review]
revert (and merge to tip) incorrect changes from bug 523496

r=bzbarsky
Attachment #452494 - Flags: review?(bzbarsky) → review+
Comment on attachment 452499 [details] [diff] [review]
implement the spec updates

r=bzbarsky
Attachment #452499 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 13

7 years ago
http://hg.mozilla.org/mozilla-central/rev/6a16094b4320
https://bugzilla.mozilla.org/show_bug.cgi?id=508452
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Priority: -- → P2
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b3
(Assignee)

Comment 14

7 years ago
er, second link should have been
http://hg.mozilla.org/mozilla-central/rev/555a6f96ec12
Duplicate of this bug: 601233
You need to log in before you can comment on or make changes to this bug.