Hixie recently made some changes to the spec for the ctx.font getter and setter; I have a work in progress patch to implement them at http://hg.mozilla.org/users/dbaron_mozilla.com/patches/file/tip/ctx-font-updates but I still need to write tests (and make sure the patch passes them).
I realize my current patch doesn't work for system fonts, though.
Is there a reference to a spec?
I also wonder if I should be editing our canvas tests directly or if there's a source form for them that's not in our tree that I should be editing instead.
http://philip.html5.org/tests/canvas/suite/tests/ may be the source of the tests; I need to investigate further to see if there's something there that puts them in the form we have.
Created attachment 452494 [details] [diff] [review] revert (and merge to tip) incorrect changes from bug 523496
Created attachment 452495 [details] [diff] [review] patch 2: remove redundant parsing of line-height Parsing the 'font' shorthand is sufficient.
Created attachment 452496 [details] [diff] [review] patch 3: implement the spec updates ... though, honestly, I'm a little skeptical, because each time I think about posting this patch, it turns out that the spec has changed again.
Comment on attachment 452496 [details] [diff] [review] patch 3: implement the spec updates Actually, I changed my mind; I can simplify this code a bit now that the requirements changed again.
Created attachment 452499 [details] [diff] [review] implement the spec updates Simpler version.
Comment on attachment 452494 [details] [diff] [review] revert (and merge to tip) incorrect changes from bug 523496 r=bzbarsky
Comment on attachment 452499 [details] [diff] [review] implement the spec updates r=bzbarsky
er, second link should have been http://hg.mozilla.org/mozilla-central/rev/555a6f96ec12
7 years ago