508452 - update to current spec for canvas ctx.font getter and setter

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Hixie recently made some changes to the spec for the ctx.font getter and setter; I have a work in progress patch to implement them at http://hg.mozilla.org/users/dbaron_mozilla.com/patches/file/tip/ctx-font-updates but I still need to write tests (and make sure the patch passes them).

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I realize my current patch doesn't work for system fonts, though.

Comment 2

[John Daggett (:jtd)]

Is there a reference to a spec?

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#text

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I also wonder if I should be editing our canvas tests directly or if there's a source form for them that's not in our tree that I should be editing instead.

Comment 5

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

http://philip.html5.org/tests/canvas/suite/tests/ may be the source of the tests; I need to investigate further to see if there's something there that puts them in the form we have.

Comment 6

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: revert (and merge to tip) incorrect changes from bug 523496

Comment 7

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: patch 2: remove redundant parsing of line-height

Parsing the 'font' shorthand is sufficient.

Comment 8

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: patch 3: implement the spec updates

... though, honestly, I'm a little skeptical, because each time I think about posting this patch, it turns out that the spec has changed again.

Comment 9

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 452496 [details] [diff] [review]
patch 3: implement the spec updates

Actually, I changed my mind; I can simplify this code a bit now that the requirements changed again.

Comment 10

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: implement the spec updates

Simpler version.

Comment 11

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 452494 [details] [diff] [review]
revert (and merge to tip) incorrect changes from bug 523496

r=bzbarsky

Comment 12

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 452499 [details] [diff] [review]
implement the spec updates

r=bzbarsky

Comment 13

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

http://hg.mozilla.org/mozilla-central/rev/6a16094b4320
https://bugzilla.mozilla.org/show_bug.cgi?id=508452

Comment 14

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

er, second link should have been
http://hg.mozilla.org/mozilla-central/rev/555a6f96ec12