COWs create too many XPCNativeWrappers

VERIFIED FIXED in mozilla1.9.2b1

Status

()

Core
XPConnect
P1
normal
VERIFIED FIXED
8 years ago
8 years ago

People

(Reporter: mrbkap, Assigned: mrbkap)

Tracking

({verified1.9.2})

Trunk
mozilla1.9.2b1
verified1.9.2
Points:
---
Bug Flags:
blocking1.9.2 +

Firefox Tracking Flags

(status1.9.2 beta1-fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
When deciding what wrapper to create for chrome, I forgot that XPCNativeWrappers refuse to wrap double-wrapped objects. We should detect this in XPC_COW_RewrapForChrome and create a SJOW instead.
Flags: blocking1.9.2?
(Assignee)

Comment 1

8 years ago
Created attachment 392656 [details] [diff] [review]
Proposed fix
Attachment #392656 - Flags: superreview?(jst)
Attachment #392656 - Flags: review?(jst)
(This blocks a P1 1.9.2 blocker)
Flags: blocking1.9.2? → blocking1.9.2+
Priority: -- → P1
Whiteboard: [needs review jst[
Whiteboard: [needs review jst[ → [needs review jst]

Updated

8 years ago
Attachment #392656 - Flags: superreview?(jst)
Attachment #392656 - Flags: superreview+
Attachment #392656 - Flags: review?(jst)
Attachment #392656 - Flags: review+
(Assignee)

Comment 3

8 years ago
http://hg.mozilla.org/mozilla-central/rev/9561bccb08fd
Whiteboard: [needs review jst]
(Assignee)

Updated

8 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Mass change: adding fixed1.9.2 keyword

(This bug was identified as a mozilla1.9.2 blocker which was fixed before the mozilla-1.9.2 repository was branched (August 13th, 2009) as per this query: http://is.gd/2ydcb - if this bug is not actually fixed on mozilla1.9.2, please remove the keyword. Apologies for the bugspam)
Keywords: fixed1.9.2
status1.9.2: --- → beta1-fixed
Keywords: fixed1.9.2
Verified fixed based on check-in.
Keywords: verified1.9.2
OS: Linux → All
Hardware: x86 → All
Target Milestone: --- → mozilla1.9.2b1
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.