508499 - simplify tab drop indicator code and styling

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Dão Gottwald [:dao]]

Attachment: WIP

Comment 1

[Dão Gottwald [:dao]]

Attachment: patch

Comment 2

[Dão Gottwald [:dao]]

Attachment: patch

updated to trunk

Comment 3

[Mike Connor [:mconnor]]

Comment on attachment 406659 [details] [diff] [review]
patch

I am no longer actively working on Firefox, please find another reviewer.

Comment 4

[Dão Gottwald [:dao]]

Attachment: patch

Comment 5

[Dão Gottwald [:dao]]

Attachment: patch

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 428213 [details] [diff] [review]
patch

This patch seems to be causing the dropmarker to appear unreliably. I tested on Mac and Linux. I can't make any sense of it, it seems like a strange layout-related issue - dumps in _onDragOver show that we're setting the margin correctly and uncollapsing the indicator, but it just doesn't actually appear in a lot of cases. I can usually get it to appear by dragging out of the tabstrip and then back in (which collapses in _dragOut and then uncollapses again in _onDragOver). Forcing a reflow at the end of onDragOver doesn't seem to have an effect.

My STR are to select a tab near the end of the tabstrip and drag it back and forth towards the beginning of the tabstrip. The dropmarker only appears sporadically. Often it will appear while dragging back towards the original location, but not when dragging away from it, which doesn't really make any sense to me. Reverting the patch makes it appear consistently again.

Comment 7

[Dão Gottwald [:dao]]

Maybe a regression from bug 526394, like bug 545049...

Comment 8

[Marco Bonardo [:mak]]

(In reply to comment #7)
> Maybe a regression from bug 526394, like bug 545049...

if it's a scrollbox, that's probably more than a maybe.

Comment 9

[Dão Gottwald [:dao]]

I would think it's position: relative; z-index: 1; rather than the scrollbox, but that's only a guess. Either way both drop indicators have a lot in common, and either way the underlying problem needs to be fixed, since it did work flawlessly when I wrote the patch.

Comment 10

[Dão Gottwald [:dao]]

I just tested the patch with mozilla-central from January 10 (worked) and from January 12 (failed), so this is very likely bug 545049.

Comment 11

[Dão Gottwald [:dao]]

Attachment: patch

updated to tip

Can we land this, knowing that it suffers from bug 545049 just like the bookmarks toolbar?

Comment 12

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 429969 [details] [diff] [review]
patch

I guess so. Maybe file a separate bug and mark it dependent, in case the fix for that bug doesn't also fix this one? Granted that's unlikely, but better safe than sorry I think.

Comment 13

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/3b49923ba8c5

Roc just took bug 545049, which I'll monitor closely. Will file a separate bug if necessary.

Comment 14

[tabmix.onemen]

this also fix the problem

+  var ib = ind.parentNode;
-  ind.style.MozTransform = "translate(" + Math.round(newMargin) + "px)";
+  ib.style.MozTransform = "translate(" + Math.round(newMargin) + "px)";
   ind.style.MozMarginStart = (-ind.clientWidth) + "px";
-  ind.style.marginTop = (-ind.clientHeight) + "px";
+  ib.style.marginTop = (-ind.clientHeight) + "px";