508508 - (polish) top pixel in tab_button_divider.tiff is too dark

Status: RESOLVED FIXED

(Camino Graveyard :: Tabbed Browsing, defect)

Description

[philippe (part-time)]

Attachment: new tab_button_divider.tiff

With the new tab-nar background, the top (left) pixel in the tab_button_divider looks much darker than the rest of the divider.

screenshots:
http://dev.l-c-n.com/camino/tab_bar/old_tab-bar.png
http://dev.l-c-n.com/camino/tab_bar/new_tabbar.png
http://dev.l-c-n.com/camino/tab_bar/tab-bar-new_divider.png

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Well, after an intensive Pixie session, I can see what you're talking about, and it's fine to fix that.  

It's not what I notice about that divider top (even without Pixie), though ;)  I think the top right pixel looks more noticeably out-of-place.

See
http://www.ardisson.org/smokey/moz/tabsv2/old-divider.png
http://www.ardisson.org/smokey/moz/tabsv2/existing-divider.png
http://www.ardisson.org/smokey/moz/tabsv2/new-divider.png
and
http://www.ardisson.org/smokey/moz/tabsv2/old-closeup.png
http://www.ardisson.org/smokey/moz/tabsv2/existing-closeup.png
http://www.ardisson.org/smokey/moz/tabsv2/new-closeup.png
(where "old" is before bug 401340, "existing" is after bug 401340, and "new" is this bug's tiff).

Comment 2

[philippe (part-time)]

(In reply to comment #1)

> It's not what I notice about that divider top (even without Pixie), though ;) 
> I think the top right pixel looks more noticeably out-of-place.

So, what do you suggest ? Making it a bit lighter but still grey-ish, closer to the pixels on the right of it ? Or more white, close to the pixels under it (to keep the emboss effect)?

fwiw, the tonal range is the same as with the old tab bar, keeping the appearance of a corner. Making the top-right pixel more white would remove that appearance.

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #2)
> (In reply to comment #1)
> 
> > It's not what I notice about that divider top (even without Pixie), though ;) 
> > I think the top right pixel looks more noticeably out-of-place.
> 
> So, what do you suggest ? Making it a bit lighter but still grey-ish, closer to
> the pixels on the right of it ? 

This, I think.  It's a similar change to what you did to the other pixel, right?

(The problem, as I understand it, is that we're now "multiplying" these pixels by darker bg colors, causing the two of them to be darker than they should be/than they were when we were multiplying them against lighter bg colors.  Is this roughly correct?)

Comment 4

[philippe (part-time)]

Attachment: tab_button_divider.tiff, version 2

in context:
http://dev.l-c-n.com/camino/tab_bar/new-divider-v2.png
http://dev.l-c-n.com/camino/tab_bar/new-divider-v2-closeup.png

(In reply to comment #3)
  
> (The problem, as I understand it, is that we're now "multiplying" these pixels
> by darker bg colors, causing the two of them to be darker than they should
> be/than they were when we were multiplying them against lighter bg colors.  Is
> this roughly correct?)

Well, before we were also multiplying the colours; the tab bar background is a bit darker now and the little drop shadow is makes the top row even darker.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 393340 [details]
tab_button_divider.tiff, version 2

This looks OK; the top right pixel doesn't stick out anymore.

Did you also lighten the entire left column to even its color back out?  I think it looks like it's lighter overall than before the new tab bar?

http://www.ardisson.org/smokey/moz/tabsv2/newv2-divider.png
http://www.ardisson.org/smokey/moz/tabsv2/newv2-closeup.png

Comment 6

[philippe (part-time)]

(In reply to comment #5)
 
> Did you also lighten the entire left column to even its color back out?  I
> think it looks like it's lighter overall than before the new tab bar?

Yes, I lighten it slightly. Is it too light ?

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #6)
> (In reply to comment #5)
> 
> > Did you also lighten the entire left column to even its color back out?  I
> > think it looks like it's lighter overall than before the new tab bar?
> 
> Yes, I lighten it slightly. Is it too light ?

Probably not, but I'd like to make sure everyone else agrees with me :)

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

[5:39pm] smorgan: I don't see anything wrong with the screenshot though
[5:39pm] smorgan: So if it makes you happy, ship it

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 393340 [details]
tab_button_divider.tiff, version 2

[5:39pm] sauron: ok ;)
[5:40pm] sauron: i'll take that as sr ;)

Comment 10

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Checked in on CAMINO_2_0_BRANCH and cvs trunk.