50873 - More Info button in Smart Browsing panel does nothing

Status: VERIFIED FIXED

(SeaMonkey :: Preferences, defect, P5)

Description

[sairuh (rarely reading bugmail)]

...well, other than indent when you click it. :)

matt/vera, is this supposed to launch a dialog or open a webpage to some online
help? or, will this actually be removed soon?

found this using 2000.08.30.08 comm bits on Mac 8.6 (claudius confirmed that it
also occurs on win98 and linux; alas, no console output available). to repro:

1. open prefs dialog
2. select the Smart Browser category
3. in the Internet Keywords section of the panel, click the More Information
button.

result: it indents, but nothing is launched.

Comment 1

[sairuh (rarely reading bugmail)]

would be nice to either remove this by beta3, or hook it up by then. unless
online help don't need to go in by then...

Comment 2

[verah (gone)]

It's supposed to go to this page:
http://info.netscape.com/fwd/rlstatic/http://home.netscape.com/escapes/keywords/
index.html

Just like the "Learn more about Internet Keywords" link in the What's Related 
Sidebar tab.

Is there someone who can make this so?

Comment 3

[Claudius Gayle]

nav triage team:nsbeta3+ please 'hook it up'.

Comment 4

[Blake Ross]

OK, I'll 'hook it up'

It should open in a new window, I assume?
Also, where should it go in Mozilla builds?

Comment 5

[Blake Ross]

Can't go any further here without more info -- vera, should it also go to that 
netscape site in Mozilla builds?

Comment 6

[verah (gone)]

Ewww,,,, I hadn't thought of that. And I can't answer it, either. Who speaks of 
Mozilla policy in such matters? 

Comment 7

[Phil Peterson]

PDT thinks this is a P5. For now, you could make it go to the mozilla.org homepage. 

Comment 8

[verah (gone)]

Okay, so for the commercial build it should go here:
http://info.netscape.com/fwd/rlstatic/http://home.netscape.com/escapes/keywords/
index.html

And for the mozilla build it should go to the mozilla home page, for now. I 
guess we need a separate bug along the line of, "mozilla.org needs a one-pager 
for end users on the subject of Internet Keywords," help wanted.

I think opening a new window is a good idea, so the user's current page doesn't 
get blown away by what it essentially an online help document.

Comment 9

[Blake Ross]

Attachment: patch - please review

Comment 10

[Blake Ross]

the patch needs review & approval...(adding keywords because this gives me a 
false sense of hope).

note that one this patch is checked in, a separate bugscape bug will need to be 
filed to change the URL to the netscape URL given for comm builds.  It's a very 
easy change to a text file, but I can't check into the comm tree.

Comment 11

[verah (gone)]

Blake -- I'll make sure the Nav triage team looks at this on Tuesday, and we'll 
get it reviewed. Thanks!

Comment 12

[Brendan Eich [:brendan]]

function moreInfo's indentation looks screwy -- please check for hard tabs and 
expand per the emacs modeline comment.

/be

Comment 13

[Blake Ross]

Attachment: patch: is this any better?

Comment 14

[Brendan Eich [:brendan]]

Yes, that does look better.  Thanks, a=[e-mail].

/be

Comment 15

[Blake Ross]

Thanks, Brendan.  Fix checked in.

Vera: could you pleaes open a new bugscape bug to change the URL to 
http://info.netscape.com/fwd/rlstatic/http://home.netscape.com/escapes/keywords/
index.html in comm builds?  In the bug, note that the only change that has to 
be made is to smartBrowsingURL

Comment 16

[Claudius Gayle]

wrote bug 52296 for the nscp comm version. No need for bugscape as there is nothing
double-secret or proprietary about this. (and if there were it's already mentioned here)

Comment 17

[Blake Ross]

Thanks for filing it.  Still, if it's a Netscape bug, it should be in Bugscape -
- not Mozilla's tracking system.  Thanks though.

Comment 18

[sairuh (rarely reading bugmail)]

verifyme, for anyone who can get to this on mozilla before i do. thx!

Comment 19

[sairuh (rarely reading bugmail)]

clearing nsbeta3+ in status to get off of my high-prio verification list. :)

Comment 20

[sairuh (rarely reading bugmail)]

vrfy fixed (some time ago, yep).