508737 - Allow Bugzilla::Template::get_bug_link to take a Bugzilla::Bug object if one is available

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Max Kanat-Alexander]

In some code that I'm working on now, I've discovered that bug_link is very very slow if you call it over and over, because it gets the bug information out of the DB every time. Often, when we call bug_link, we have a Bug object already available, so we should just allow it to re-use the information we already have, there.

Comment 1

[Max Kanat-Alexander]

Attachment: v1

Here we go.

A future further optimization could be to cache bugs that we look up and re-use them from the cache if they are already there.

Comment 2

[Frédéric Buclin]

Comment on attachment 392885 [details] [diff] [review]
v1

r=LpSolit

Comment 3

[Max Kanat-Alexander]

I made a tiny change on checkin--in the $bug->resolution block, I used .= instead of = on $pre and $post, in case in the future there's some weird thing where UNCONFIRMED can be a closed resolution.

Checking in Bugzilla/Template.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Template.pm,v  <--  Template.pm
new revision: 1.103; previous revision: 1.102
done
Checking in template/en/default/attachment/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/create.html.tmpl,v  <--  create.html.tmpl
new revision: 1.41; previous revision: 1.40
done
Checking in template/en/default/attachment/show-multiple.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/show-multiple.html.tmpl,v  <--  show-multiple.html.tmpl
new revision: 1.26; previous revision: 1.25
done
Checking in template/en/default/bug/activity/show.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/activity/show.html.tmpl,v  <--  show.html.tmpl
new revision: 1.11; previous revision: 1.10
done
Checking in template/en/default/bug/process/midair.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/process/midair.html.tmpl,v  <--  midair.html.tmpl
new revision: 1.24; previous revision: 1.23
done
Checking in template/en/default/bug/votes/list-for-user.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/votes/list-for-user.html.tmpl,v  <--  list-for-user.html.tmpl
new revision: 1.29; previous revision: 1.28
done