508795 - Make Error.prototype.toString conform to spec

Status: RESOLVED FIXED

(Rhino Graveyard :: Core, defect)

Description

[rspeyer]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_5_7; en-US) AppleWebKit/532.0 (KHTML, like Gecko) Chrome/3.0.196 Safari/532.0
Build Identifier: Rhino 1.7 release 2 2009 03 22

As detailed in 15.11.4.4

Reproducible: Always

Comment 1

[rspeyer]

Attachment: implemented Error.prototype.toString as per spec

Specified in section 15.11.4.4

Comment 2

[Norris Boyd]

Need to investigate, may be invalid test:

    [junit] /home/norris/rhino17/mozilla/js/tests/ecma_3/Exceptions/regress-181914.js:169: uncaught JavaScript runtime exception: TypeError: Cannot call method "search" of undefined

Comment 3

[Norris Boyd]

Committed.

Checking in src/org/mozilla/javascript/NativeError.java;
/cvsroot/mozilla/js/rhino/src/org/mozilla/javascript/NativeError.java,v  <--  NativeError.java
new revision: 1.48; previous revision: 1.47
done
Checking in testsrc/opt-1.tests;
/cvsroot/mozilla/js/rhino/testsrc/opt-1.tests,v  <--  opt-1.tests
new revision: 1.8; previous revision: 1.7
done
Checking in testsrc/opt0.tests;
/cvsroot/mozilla/js/rhino/testsrc/opt0.tests,v  <--  opt0.tests
new revision: 1.8; previous revision: 1.7
done
Checking in testsrc/opt9.tests;
/cvsroot/mozilla/js/rhino/testsrc/opt9.tests,v  <--  opt9.tests
new revision: 1.8; previous revision: 1.7
done
RCS file: /cvsroot/mozilla/js/rhino/testsrc/doctests/error.tostring.doctest,v
done
Checking in testsrc/doctests/error.tostring.doctest;
/cvsroot/mozilla/js/rhino/testsrc/doctests/error.tostring.doctest,v  <--  error.tostring.doctest
initial revision: 1.1
done

Comment 4

[Hannes Wallnoefer]

Note: the removal of NativeError.toString() in the patch for this bug caused JS errors to be rendered as org.mozilla.javascript.NativeError@1e4f7c2 on the Java side. I just committed a revision that reestablishes the old behaviour unless js_toString() returns undefined.

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/js/rhino/src/org/mozilla/javascript&command=DIFF_FRAMESET&file=NativeError.java&rev1=1.48&rev2=1.49&root=/cvsroot