508902 - NetUtil.jsm should have a newURI method

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Shawn Wilsher :sdwilsh]

Most code that has to create URIs ends up storing the IOService itself and creating the URI.  We can do better by storing it in NetUtil, and adding a new method:
newURI(aSpec, aCharset, aBaseURI)
The signature is identical to nsIOService::newURI, but callers could not specify null for aCharset and aBaseURI like they currently have to.

Comment 1

[Shawn Wilsher :sdwilsh]

Attachment: v1.0

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 397662 [details] [diff] [review]
v1.0

r=bzbarsky

Comment 3

[Shawn Wilsher :sdwilsh]

http://hg.mozilla.org/mozilla-central/rev/af96727dcc71

Comment 4

[Eric Shepherd [:sheppy]]

Is there any plan to bring this to 1.9.2? Trying to plan docs for NetUtil.jsm.

Comment 5

[Shawn Wilsher :sdwilsh]

(In reply to comment #4)
> Is there any plan to bring this to 1.9.2? Trying to plan docs for NetUtil.jsm.
The change would be trivial.  It's only additive so we could ask for approval.  It'd need the minor fix I added in http://hg.mozilla.org/mozilla-central/rev/ec44dfe85a0d too.

Comment 6

[Shawn Wilsher :sdwilsh]

(In reply to comment #5)
> It'd need the minor fix I added in
> http://hg.mozilla.org/mozilla-central/rev/ec44dfe85a0d too.
Er, this is for a different bug!  However, this likely won't be added to 1.9.2 since it'd require backporting a few other bugs too (see dependency tree).

Comment 7

[Eric Shepherd [:sheppy]]

OK, good to know this won't come to 1.9.2. I'll watch for this in 1.9.3.

Comment 8

[Shawn Wilsher :sdwilsh]

Documentation added to https://developer.mozilla.org/en/JavaScript_code_modules/NetUtil.jsm.  Sheppy should look it over to make sure I didn't do something stupid :)

Comment 9

[Eric Shepherd [:sheppy]]

Did. Nothing stupid, I tweaked the formatting slightly in a couple places. Thanks!

Comment 10

[Shawn Wilsher :sdwilsh]

Comment on attachment 397662 [details] [diff] [review]
v1.0

rob tells me this fixes a bug on 1.9.2 with the aero peek stuff.  He'll add the bug to the dependency chain.  This is a strictly additive API addition that would be a nice to have for 1.9.2.  It has tests!

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 397662 [details] [diff] [review]
v1.0

a192=beltzner

Comment 12

[Rob Arnold [:robarnold]]

Pushed to mozilla-1.9.2:
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/ee2d16185a71

Setting dev-doc-needed since this is now available on 1.9.2 (sorry for doing this again Sheppy!)

Comment 13

[Eric Shepherd [:sheppy]]

Better this than me finding out after we ship it. Thanks!

Comment 14

[Eric Shepherd [:sheppy]]

The docs already said it was available in 1.9.2, so we're good to go :)

Comment 15

[Shawn Wilsher :sdwilsh]

(In reply to comment #14)
> The docs already said it was available in 1.9.2, so we're good to go :)
It said that for NetUtil.jsm, but it said 1.9.3 for newURI.  I've fixed it here:
https://developer.mozilla.org/index.php?title=en/JavaScript_code_modules/NetUtil.jsm&action=diff&revision=12&diff=13