Closed Bug 508902 Opened 11 years ago Closed 11 years ago

NetUtil.jsm should have a newURI method

Categories

(Core :: Networking, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.3a1
Tracking Status
status1.9.2 --- beta1-fixed

People

(Reporter: sdwilsh, Assigned: sdwilsh)

References

()

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

Most code that has to create URIs ends up storing the IOService itself and creating the URI.  We can do better by storing it in NetUtil, and adding a new method:
newURI(aSpec, aCharset, aBaseURI)
The signature is identical to nsIOService::newURI, but callers could not specify null for aCharset and aBaseURI like they currently have to.
Attached patch v1.0Splinter Review
Attachment #397662 - Flags: superreview?(benjamin)
Attachment #397662 - Flags: review?(bzbarsky)
Group: mozilla-confidential
Whiteboard: [needs review bz][needs sr bsmedberg]
Group: mozilla-confidential
Comment on attachment 397662 [details] [diff] [review]
v1.0

r=bzbarsky
Attachment #397662 - Flags: review?(bzbarsky) → review+
Whiteboard: [needs review bz][needs sr bsmedberg] → [needs sr bsmedberg]
Attachment #397662 - Flags: superreview?(benjamin) → superreview+
Whiteboard: [needs sr bsmedberg] → [can land]
http://hg.mozilla.org/mozilla-central/rev/af96727dcc71
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Keywords: dev-doc-needed
Resolution: --- → FIXED
Whiteboard: [can land]
Target Milestone: --- → mozilla1.9.3a1
Is there any plan to bring this to 1.9.2? Trying to plan docs for NetUtil.jsm.
Whiteboard: [doc-waiting-info]
(In reply to comment #4)
> Is there any plan to bring this to 1.9.2? Trying to plan docs for NetUtil.jsm.
The change would be trivial.  It's only additive so we could ask for approval.  It'd need the minor fix I added in http://hg.mozilla.org/mozilla-central/rev/ec44dfe85a0d too.
(In reply to comment #5)
> It'd need the minor fix I added in
> http://hg.mozilla.org/mozilla-central/rev/ec44dfe85a0d too.
Er, this is for a different bug!  However, this likely won't be added to 1.9.2 since it'd require backporting a few other bugs too (see dependency tree).
OK, good to know this won't come to 1.9.2. I'll watch for this in 1.9.3.
Whiteboard: [doc-waiting-info] → [doc-waiting-1.9.3]
Documentation added to https://developer.mozilla.org/en/JavaScript_code_modules/NetUtil.jsm.  Sheppy should look it over to make sure I didn't do something stupid :)
Whiteboard: [doc-waiting-1.9.3]
Did. Nothing stupid, I tweaked the formatting slightly in a couple places. Thanks!
Comment on attachment 397662 [details] [diff] [review]
v1.0

rob tells me this fixes a bug on 1.9.2 with the aero peek stuff.  He'll add the bug to the dependency chain.  This is a strictly additive API addition that would be a nice to have for 1.9.2.  It has tests!
Attachment #397662 - Flags: approval1.9.2?
Blocks: 474056
Comment on attachment 397662 [details] [diff] [review]
v1.0

a192=beltzner
Attachment #397662 - Flags: approval1.9.2? → approval1.9.2+
Pushed to mozilla-1.9.2:
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/ee2d16185a71

Setting dev-doc-needed since this is now available on 1.9.2 (sorry for doing this again Sheppy!)
Better this than me finding out after we ship it. Thanks!
The docs already said it was available in 1.9.2, so we're good to go :)
(In reply to comment #14)
> The docs already said it was available in 1.9.2, so we're good to go :)
It said that for NetUtil.jsm, but it said 1.9.3 for newURI.  I've fixed it here:
https://developer.mozilla.org/index.php?title=en/JavaScript_code_modules/NetUtil.jsm&action=diff&revision=12&diff=13
You need to log in before you can comment on or make changes to this bug.