508965 - Product name support in signing Makefile

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Chris AtLee [:catlee]]

In the 3.6a1 release, we needed to hack the Makefile so that the proper product got passed to sign-release.py.

Should PRODUCT=namoroka have been set for this release?  And if so, how does that affect how we calculate PRODUCT_DIR, which is used for checking out the stubs.

The sign-files target should be modified so that it calls sign-release.py with --product=$(PRODUCT) or $(PRODUCT_NAME) or $(BRAND_NAME) or something.

Comment 1

[[e-mail] (:bhearsum)]

For what it's worth, the old signing scripts deal with this by regexes like the following:
$OLD_WIN32_EXE_REGEX = '\.win32\.installer\.exe$';
$OLD_WIN32_MAR_EXT = '.win32.complete.mar';
$NEW_WIN32_EXE_REGEX = '([\w-]+)\/(\w+)\ Setup\ ([\d\.]+)(\ \w+\ \d+)?\.exe';

Comment 2

[Chris AtLee [:catlee]]

Attachment: Add BRAND_NAME, APP_NAME to Makefile

Also sets WORKDIR to $(PWD), which is equivalent to what we're doing for regular releases, but makes testing easier!

So far 3.6a1 we would have called make with BRAND_NAME=namoroka

Comment 3

[[e-mail] (:bhearsum)]

Comment on attachment 393215 [details] [diff] [review]
Add BRAND_NAME, APP_NAME to Makefile

This seems fine, but can you default BRAND_NAME to $(PRODUCT) rather than firefox?

Comment 4

[alice nodelman [:alice] [:anode]]

catlee seems to be working on this, assigning to him.

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 393215 [details] [diff] [review]
Add BRAND_NAME, APP_NAME to Makefile

Looks fine.

Comment 6

[Chris AtLee [:catlee]]

Comment on attachment 393215 [details] [diff] [review]
Add BRAND_NAME, APP_NAME to Makefile

changeset:   343:cb02be8882aa