509108 - Don't require a bug_list parameter to show the bug template

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, enhancement)

Description

[Max Kanat-Alexander]

We should be able to get the last bug list that was generated, always, as a template variable.

Comment 1

[Max Kanat-Alexander]

Attachment: v1

Okay, this seems to work okay.

I removed the <link> tags from site-navigation. I haven't seen any browser that does anything useful with them other than elinks/lynx, and I'm not really too worried about that particular browser. I removed them because last_bug_list is now *always* defined, and it doesn't make sense to have these links defined on every page.

Comment 2

[Frédéric Buclin]

Comment on attachment 393268 [details] [diff] [review]
v1

>=== modified file 'process_bug.cgi'

> my @bug_list;
> if ($cgi->cookie("BUGLIST")) {
>     @bug_list = split(/:/, $cgi->cookie("BUGLIST"));
>-    $vars->{'bug_list'} = \@bug_list;
> }

Please move the remaining code in the |if ($action eq 'next_bug')| block, which is the only one to care about this cookie.



>=== modified file 'template/en/default/bug/navigate.html.tmpl'

> [% IF this_bug_idx != -1 %]
>+  <a href="show_bug.cgi?id=[% last_bug_list.first FILTER url_quote %]">First</a>
>+  <a href="show_bug.cgi?id=[% last_bug_list.last FILTER url_quote %]">Last</a>
> [% END %]

Nit: while you are on it, please fix the indentation. This IF block should be 2 characters on the right.

r=LpSolit

Comment 3

[Max Kanat-Alexander]

Checking in post_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/post_bug.cgi,v  <--  post_bug.cgi
new revision: 1.202; previous revision: 1.201
done
Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.421; previous revision: 1.420
done
Checking in show_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/show_bug.cgi,v  <--  show_bug.cgi
new revision: 1.60; previous revision: 1.59
done
No route to host at /usr/lib/perl5/vendor_perl/5.8.8/Mail/Mailer.pm line 151, <> line 9.
Checking in Bugzilla/Template.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Template.pm,v  <--  Template.pm
new revision: 1.106; previous revision: 1.105
done
No route to host at /usr/lib/perl5/vendor_perl/5.8.8/Mail/Mailer.pm line 151, <> line 9.
Checking in template/en/default/filterexceptions.pl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/filterexceptions.pl,v  <--  filterexceptions.pl
new revision: 1.129; previous revision: 1.128
done
No route to host at /usr/lib/perl5/vendor_perl/5.8.8/Mail/Mailer.pm line 151, <> line 9.
Checking in template/en/default/bug/navigate.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/navigate.html.tmpl,v  <--  navigate.html.tmpl
new revision: 1.12; previous revision: 1.11
done
Checking in template/en/default/bug/create/created.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/created.html.tmpl,v  <--  created.html.tmpl
new revision: 1.17; previous revision: 1.16
done
Checking in template/en/default/global/site-navigation.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/site-navigation.html.tmpl,v  <--  site-navigation.html.tmpl
new revision: 1.27; previous revision: 1.26
done


Oh, and the checkin fixes:

Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.422; previous revision: 1.421
done
Checking in template/en/default/bug/navigate.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/navigate.html.tmpl,v  <--  navigate.html.tmpl
new revision: 1.13; previous revision: 1.12
done