Closed Bug 509156 Opened 14 years ago Closed 14 years ago

"ASSERTION: Going to leak style data" with -moz-right, table

Categories

(Core :: CSS Parsing and Computation, defect)

Product:
Core
Component:
CSS Parsing and Computation
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.2b1

People

(Reporter: jruderman, Assigned: bzbarsky)

References

Details

(Keywords: assertion, testcase)

Attachments

(2 files)

testcase
137 bytes, text/html
Details
Fix. GetUniqueStyleData will SetStyle() when we already have a struct
1.83 KB, patch
dbaron
: review+
Details | Diff | Splinter Review
Attached file testcase — 
###!!! ASSERTION: Going to leak style data: '!*reinterpret_cast<void**>(dataSlot)', file layout/style/nsStyleContext.cpp, line 307

This assertion was added in bug 508919.
FWIW, I don't see any trace-refcnt leaks or framearena assertions.  Is there really a leak here?
Yeah, this assert was slightly bogus.  We're not leaking because we don't own the struct whose pointer is being clobbered!
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #393324 - Flags: review?(dbaron)
Comment on attachment 393324 [details] [diff] [review]
Fix.  GetUniqueStyleData will SetStyle() when we already have a struct

r=dbaron
Attachment #393324 - Flags: review?(dbaron) → review+
Pushed http://hg.mozilla.org/mozilla-central/rev/64d9f32cf21e
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2b1
You need to log in before you can comment on or make changes to this bug.