509198 - Sisyphus - directly mount dmg installer

Status: RESOLVED FIXED

(Testing Graveyard :: Sisyphus, defect)

Description

[Bob Clary [:bc] (inactive)]

Attachment: patch

Currently Sisyphus installs Mac OS X dmg builds using hdiutil to attach the file and the expect program to answer any licensing questions. In general this functionality isn't used in practice since Sisyphus is usually used to create its own builds. 

This broke some time ago and is too fragile in general. This patch changes this to directly mount the installer as a subdirectory of /tmp and to copy the files from their to the destination. This is supported on Mac OS X 10.4 and later.

This assumes only one fixed mount point. To generalize to include simultaneous installs it would require generating an unique mount point. I don't think that is necessary for the moment, but can be easily added later if required.

Comment 1

[cmtalbert]

Comment on attachment 393361 [details] [diff] [review]
patch

Cool, looks good.

Comment 2

[Bob Clary [:bc] (inactive)]

http://hg.mozilla.org/tracemonkey/rev/fd2d7f7db7f5
Removing testing/sisyphus/bin/hdiutil-expect.ex;
/cvsroot/mozilla/testing/sisyphus/bin/hdiutil-expect.ex,v  <--  hdiutil-expect.ex
new revision: delete; previous revision: 1.1
done
Checking in testing/sisyphus/bin/install-build.sh;
/cvsroot/mozilla/testing/sisyphus/bin/install-build.sh,v  <--  install-build.sh
new revision: 1.11; previous revision: 1.10
done