Ensure that RolloverImageButton doesn't get destroyed during mousedown handling

RESOLVED FIXED

Status

Camino Graveyard
Tabbed Browsing
RESOLVED FIXED
9 years ago
8 years ago

People

(Reporter: Stuart Morgan, Assigned: Stuart Morgan)

Tracking

({fixed1.8.1.24})

unspecified
x86
Mac OS X
fixed1.8.1.24

Details

(Whiteboard: [camino-2.0])

Attachments

(1 attachment)

1.00 KB, patch
Mike Pinkerton (not reading bugmail)
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

9 years ago
Created attachment 393427 [details] [diff] [review]
prevent crash

This should fix
http://crash-stats.mozilla.com/report/index/c2e8c4d8-451e-4f1c-a910-84d422090809
which I ran into this morning, although I wasn't able to figure out the exact circumstances to reproduce it.
Attachment #393427 - Flags: superreview?(mikepinkerton)
Stuart, will this fix TB55842208x, TB55842203x, and TB55641090x, or are they different?
(Assignee)

Comment 2

9 years ago
Nope, those are all during initial setup of a tab, not handling a close. I can't see how the method at the top of the stack could crash though, so I'm wondering if it was something wacky on with one person's build or machine.
Assignee: nobody → stuart.morgan+bugzilla
Could bp-5b10adfa-7c51-4ef3-bfa1-5face2090806 be this crash?
(Assignee)

Comment 4

9 years ago
Hrm... not if it's still inside the call to [super mouseDown:], as the line number indicates. Maybe there's a deeper problem here?
Comment on attachment 393427 [details] [diff] [review]
prevent crash

sr=pink
Attachment #393427 - Flags: superreview?(mikepinkerton) → superreview+
Stuart, would you like me to land this for you, or will you be able to get to it soon?
(Assignee)

Comment 7

8 years ago
If you could land it that would be awesome. If not I should be able to do it this weekend.
Checked in on cvs trunk and CAMINO_2_0_BRANCH.

Is this something we should conceivably take for 1.6.x?
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Whiteboard: [camino-2.0]
(Assignee)

Comment 9

8 years ago
Couldn't hurt, if we end up doing a 1.6.10
Flags: camino1.6.10?
Checked in on MOZILLA_1_8_BRANCH in advance of 1.6.10.
Flags: camino1.6.10? → camino1.6.10+
Keywords: fixed1.8.1.24
You need to log in before you can comment on or make changes to this bug.