509311 - Ensure that RolloverImageButton doesn't get destroyed during mousedown handling

Status: RESOLVED FIXED

(Camino Graveyard :: Tabbed Browsing, defect)

Description

[Stuart Morgan]

Attachment: prevent crash

This should fix
http://crash-stats.mozilla.com/report/index/c2e8c4d8-451e-4f1c-a910-84d422090809
which I ran into this morning, although I wasn't able to figure out the exact circumstances to reproduce it.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Stuart, will this fix TB55842208x, TB55842203x, and TB55641090x, or are they different?

Comment 2

[Stuart Morgan]

Nope, those are all during initial setup of a tab, not handling a close. I can't see how the method at the top of the stack could crash though, so I'm wondering if it was something wacky on with one person's build or machine.

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Could bp-5b10adfa-7c51-4ef3-bfa1-5face2090806 be this crash?

Comment 4

[Stuart Morgan]

Hrm... not if it's still inside the call to [super mouseDown:], as the line number indicates. Maybe there's a deeper problem here?

Comment 5

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 393427 [details] [diff] [review]
prevent crash

sr=pink

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Stuart, would you like me to land this for you, or will you be able to get to it soon?

Comment 7

[Stuart Morgan]

If you could land it that would be awesome. If not I should be able to do it this weekend.

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Checked in on cvs trunk and CAMINO_2_0_BRANCH.

Is this something we should conceivably take for 1.6.x?

Comment 9

[Stuart Morgan]

Couldn't hurt, if we end up doing a 1.6.10

Comment 10

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Checked in on MOZILLA_1_8_BRANCH in advance of 1.6.10.