509449 - Minimized browser window restores during page loads

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect, P2)

Description

[Alice0775 White]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.3pre) Gecko/20090810 Firefox/3.5.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a2pre) Gecko/20090810 Minefield/3.6a2pre ID:20090810050215

Window minimizes to the Taskbar, but returns to previous(maximized or normal) state.


Reproducible: Always

Steps to Reproduce:
1. Start Minefield with new profile
2. Bookmarks > Select "Mozilla Firefox" > Right click > Open All in Tabs
3. Minimize window immediately (Before these pages finish loading)

Actual Results:  
The browser window returns to previous size.

Expected Results:  
The window remains minimized state.

See, related discussion  http://forums.mozillazine.org/viewtopic.php?p=7202835#p7202835

[Regression window]
Fine:
http://hg.mozilla.org/mozilla-central/rev/1c95611e9df3
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090716 Minefield/3.6a1pre ID:20090716050957

Broken:
http://hg.mozilla.org/mozilla-central/rev/ad2c0824b099
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090717 Minefield/3.6a1pre ID:20090717045648

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=1c95611e9df3&tochange=ad2c0824b099

Comment 1

[Rob Arnold [:robarnold]]

Seems like a regression from bug 502713 - I wonder if bug 489258 might fix this.

Comment 2

[Jim Jeffery not reading bug-mail 1/2/11]

Also happens on Vista and Win7 RC.

Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2a2pre) Gecko/20090810 Minefield/3.6a2pre Firefox/3.6 (.NET CLR 3.5.30729) ID:20090810050215

Comment 4

[Jim Mathies [:jimm]]

This looks more like an issue with the focus manager, or maybe our Focus widget call which restores the window. It happens when the document finishes loading. Here's the call stack:

gkwidget.dll!nsWindow::SetFocus(int aRaise=1)
gklayout.dll!nsFocusManager::Focus(nsPIDOMWindow * aWindow=0x045dc300, nsIContent * aContent=0x00000000, unsigned int aFlags=0, int aIsNewDocument=1, int aFocusChanged=0, int aWindowRaised=0)
gklayout.dll!nsFocusManager::WindowShown(nsIDOMWindow * aWindow=0x055fb060)
gklayout.dll!nsGlobalWindow::SetReadyForFocus()
gklayout.dll!nsGlobalWindow::SetReadyForFocus()
gklayout.dll!PresShell::UnsuppressAndInvalidate()
gklayout.dll!PresShell::UnsuppressPainting()
gklayout.dll!PresShell::sPaintSuppressionCallback(nsITimer * aTimer=0x0ae518d8, void * aPresShell=0x056013c8)

Comment 5

[Jim Mathies [:jimm]]

Also, backing out bug 502713 doesn't fix the problem. I'm  not sure that regression range is accurate. Reproducing it is a little tricky, I'll try and put together a test case.

Comment 6

[Neil Deakin]

What needs to happen to fix this is:

1. Check in the fix for bug 502123.
2. Change nsWindow::SetFocus to not restore when the aRaise argument is false. In fact, if aRaise is false and the window is minimized, the method should really just do nothing.

Jim, want to try something like this?

Comment 7

[Jim Mathies [:jimm]]

Attachment: patch v.1

That looks to have addressed it. I fired off a cumulative patch to try for test runs.

Comment 8

[Jim Mathies [:jimm]]

http://hg.mozilla.org/mozilla-central/rev/3bfa6d0acf3d

Comment 9

[Jim Mathies [:jimm]]

waiting on approval for bug 502123 before this can land on branch.

Comment 10

[Jim Mathies [:jimm]]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/40ad5e82d250