509558 - Need to package nssdbm3.chk for NSS >= 3.12.4 (Firefox 3.6a1 doesn't support FIPS mode)

Status: VERIFIED FIXED

(Firefox Build System :: General, defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: Package nssdbm3.chk

mozilla-central is using NSS 3.12.4, which requires a nssdbm3.chk next to nssdbm3.dll to run in FIPS mode (in addition to freebl3.chk and softokn3.dll). While the NSS build creates dist/lib/nssdbm3.chk it's not copied to dist/bin, and the Mozilla packaging isn't recreating it when we do that for the other two chk's. This affects all Toolkit-based apps probably, and certainly Firefox 3.6a1. We should fix it in mozilla-central (and mozilla-1.9.2 if we don't finish here before branching). As mentioned in  bug 504523 comment 69 it's not a problem for mozilla-1.9.1 while that continues to use NSS 3.12.3.

The parts of this patch are:
* security/manager/Makefile.in - copy nssdbm3.chk to dist/bin
* toolkit/mozapps/installer/packager.mk - linux, mac, and windows zip/mar files end up in stage-package when you go 'make package', and the chk files are recreated there, so do all three
* browser/installer/{windows,linux}/packages-static - copy nssdbm3.chk out of dist/bin, this is mainly for 'make installer' on windows

This works on the try server, except for some weird mac issue where we get no chk files on all builds there.

r? on Ted for the Core parts, need a reviewer suggestion for the security/manager/Makefile.in change.

Comment 1

[(not currently active) Ted Mielczarek]

Comment on attachment 393611 [details] [diff] [review]
Package nssdbm3.chk

*sigh*, packaging fail again! (also, my review is good for the other makefile bits.)

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

http://hg.mozilla.org/mozilla-central/rev/2179cdabf26b

Comment 3

[Mark Banner (:standard8)]

Ported to Thunderbird with blanket rs=philor

http://hg.mozilla.org/comm-central/rev/640bfbf578be

Comment 4

[Robert Kaiser]

Bah, I had hoped we would be able to fix that in Thunderbirs, SeaMonkey and possibly Sunbird at one. Now I have to do yet another patch for the rest :(

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Mass change: adding fixed1.9.2 keyword

(This bug was identified as a mozilla1.9.2 blocker which was fixed before the mozilla-1.9.2 repository was branched (August 13th, 2009) as per this query: http://is.gd/2ydcb - if this bug is not actually fixed on mozilla1.9.2, please remove the keyword. Apologies for the bugspam)

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

We'll need this when bug 504080 causes NSS 3.12.4 to land on mozilla-1.9.1.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed on 1.9.2 with builds on all platforms. The file *nssdbm3.chk is present everywhere.

Comment 8

[Daniel Veditz [:dveditz]]

Comment on attachment 393611 [details] [diff] [review]
Package nssdbm3.chk

Approved for 1.9.1.4, a=dveditz

Comment 9

[Wan-Teh Chang]

Nick: I will push your patch to mozilla-1.9.1 when I
land NSS 3.12.4 in mozilla-1.9.1.

Comment 10

[Nick Thomas [:nthomas] (UTC+12)]

Thanks Wan-Teh, and for catching all the non-Firefox packaging cases.

Comment 11

[Wan-Teh Chang]

I pushed the patch to mozilla-1.9.1 in changeset 2eb7a1915703:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/2eb7a1915703

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed on 1.9.1 with builds on all platforms like Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.4pre) Gecko/20090916 Shiretoko/3.5.4pre ID:20090916030838. The file *nssdbm3.chk is present everywhere.

Comment 13

[Reed Loden [:reed]]

So, the patch that landed on trunk (http://hg.mozilla.org/mozilla-central/rev/2179cdabf26b) is different from the one that landed on 1.9.1 (http://hg.mozilla.org/releases/mozilla-1.9.1/rev/2eb7a1915703). Is there a reason for this discrepancy?

Comment 14

[Reed Loden [:reed]]

(In reply to comment #13)
> So, the patch that landed on trunk
> (http://hg.mozilla.org/mozilla-central/rev/2179cdabf26b) is different from the
> one that landed on 1.9.1
> (http://hg.mozilla.org/releases/mozilla-1.9.1/rev/2eb7a1915703). Is there a
> reason for this discrepancy?

Ah, bug 509319 modified trunk to be the same as the 1.9.1 patch, so all good.

Comment 15

[Robert Kaiser]

This needs an update to patcher configs as well to keep partial updates working, see bug 522943