509637 - NJ: container nits

Status: RESOLVED WONTFIX

(Core Graveyard :: Nanojit, defect)

Description

[Graydon Hoare :graydon]

The containers in nanojit/Containers.{h,cpp} have a number of issues:

  - The TreeMap should really have a balance method, even if it's delayed.
  - The HashMap limits itself to int32_t and uint32_t in places it should be using uintptr_t and intptr_t or size_t.
  - The BitSet uses int in places it should prefer size_t.
  - The Seq constructor takes a copy and makes a copy rather than taking a const ref.
  - All the associative map accessors take and return copies rather than refs.
  - The associative maps don't take hashing or comparator parameters.
  - The TreeMap should probably have an iterator as well as the HashMap.

Fix these.

Comment 1

[Graydon Hoare :graydon]

Long obsolete.