509670 - Safebrowsing favicon is distorted

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[philippe (part-time)]

Attachment: screenshot

The favicon for the safebrowsing overlay page -as displayed in the locationbar- is distorted. The source image (popup_blocked_icon.tiff) displays a circle of 14px by 14px; in the locationbar, the image is displayed as a circle of 15px by 15px.

It displays correctly on the tab bar (see attached screenshot). Also visible in attachment (id=392880) (WIP v2 in bug 480207).

On the safebrowsing warning bar it also displays incorrectly (and on the popup blocking bar…).

tested with 2.0b4pre (1.9.0.14pre 2009081100) - and some 2.1a tinderbox builds

some Pixie pixel-counting:
http://dev.l-c-n.com/camino/sf_browsing/favicon-tabbar.png
http://dev.l-c-n.com/camino/sf_browsing/favicon-urlbar.png
http://dev.l-c-n.com/camino/sf_browsing/popupblocker.png
http://dev.l-c-n.com/camino/sf_browsing/warningbar.png

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Is it correct in the pop-up blocker bar?

l10n if we have to fix the nibs....

Comment 2

[philippe (part-time)]

(In reply to comment #1)
> Is it correct in the pop-up blocker bar?
yes...
http://dev.l-c-n.com/camino/sf_browsing/popupblocker.png

I  don't think that is new, though (at least, the 20090701 build shows the same issue). And for both the pop-up blocker bar and the safe browsing bar, it is much harder to see.

Comment 3

[philippe (part-time)]

Fwiw: there may be something wrong with the image (popup_blocked_icon.tiff). I renamed 'error_page_site_icon.tiff' to 'popup_blocked_icon.tiff' and accessed the url. The favicon in the location bar and on the tab display correctly.

The image still displays wrong/distorted on the blocking bars (safe browsing & pop-up blocking), though.

I'll try rebuilding the popup_blocked_icon.tiff image this PM and see what/where it brings us.

Comment 4

[philippe (part-time)]

Attachment: screen, rebuild icon - WIP1

A quick rebuild of the popup_blocked_icon.tiff image.
The odd distortion in the location-bar is gone.

The shadow still looks a little weak; not sure if I can do better.
----

This does not solve the problem with the blocker bars, though (which went undetected for a long time, Camino 1.6.8 suffers from the same in the popup blocker bar).

Comment 5

[philippe (part-time)]

Attachment: screenshot, blocker-bar WIP1

The pop-up blocking bar suffers from the same resizing.

Comment 6

[philippe (part-time)]

Attachment: rebuild popup_blocked_icon.tiff - v1.1

The actual icon for playing along.
Slightly tweaked shadow compared to the previously attached screenshot(s).

Comment 7

[philippe (part-time)]

Looking at the nib (SafeBrowsingBar.nib), the image placeholder has a width & height of 17, and under Image View > scaling is set to 'Axes Independently'. Setting that to 'None' eliminates the image distortion.
Is that the way to fix it ? I must confess that I'm just a little out of my league here …

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #7)
> Looking at the nib (SafeBrowsingBar.nib), the image placeholder has a width &
> height of 17, and under Image View > scaling is set to 'Axes Independently'.
> Setting that to 'None' eliminates the image distortion.
> Is that the way to fix it ? I must confess that I'm just a little out of my
> league here …

If you set the dimensions to 16x16, does that also fix it?  If so, does it look better (overall, in context of the whole bar) than setting scaling to "None"?

Since we're touching the SafeBrowsingBar nib right now, I'd like fix that one before committing bug 509468 if we can.  I'm really not sure what is the better fix, nor why we went with 17x17 (I suspect to match the height of the text/buttons), though.

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #8)
> fix, nor why we went with 17x17 (I suspect to match the height of the
> text/buttons), though.

Or to match the popup_close* buttons, which are 17x17, all of it actual pixels.

Comment 10

[philippe (part-time)]

(In reply to comment #8)
> (In reply to comment #7)

> If you set the dimensions to 16x16, does that also fix it?  If so, does it look
> better (overall, in context of the whole bar) than setting scaling to "None"?

Both changes work well. Setting the size to 16x16 might actually be slightly better, the image is positioned 1 pixel lower, the bottom alignment matches that of the close button.

Comment 11

[philippe (part-time)]

Attachment: screenshot safe-browsing warning bar @16x16

screenshot of the warning bar with image size set to 16x16. I used a tweaked popup_blocked_icon.tiff

Comment 12

[philippe (part-time)]

Attachment: popup_blocked_icon.tiff - v1.2

Some more tweaks to make the image display as well as possible on all backgrounds.

Smokey, does this look OK ?

Comment 13

[philippe (part-time)]

Attachment: updated SafeBrowsingBar.nib

Update nib, set the size of the image to 16x16. Hopefully I didn't mess up with anything…
Saved with IB 3.1.2 on 10.5.8.

The PopupBlockView.nib will need a similar tweak.

Comment 14

[philippe (part-time)]

(In reply to comment #13)
> Created an attachment (id=394444) [details]
> updated SafeBrowsingBar.nib
>

Or better wait for the nib in bug 509468 to land first ?

Comment 15

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

If making the image 16x16 is the right fix, I'll just do it for that nib when landing bug 509468 ;)  I'll talk to others about it today (the screenshots look OK, though I haven't built with it).

Comment 16

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 394444 [details]
updated SafeBrowsingBar.nib

Per Stuart, the correct fix is to set the image dimensions to 16x16 and the scaling to none.  I've done that for SafeBrowsingBar.nib in the checkin for bug 509468.

We'll need to apply the same fixes (and a couple of 1px moves to keep the appropriate spacing) to the PopupBlocked nib here, and then fix the icon.

Comment 17

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Updated PopupBlockView.nib

Here's the PopupBlockView.nib with the same fixes applied.

Comment 18

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #3)
> Fwiw: there may be something wrong with the image (popup_blocked_icon.tiff). I

Preview claims that the current icon is 71 px/in, which could be it.

Comment 19

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 394443 [details]
popup_blocked_icon.tiff - v1.2

I'd rather use Jon's icon with the dpi corrected, for two reasons:

1) The shadow is stronger/darker, which helps in the location bar
2) The white outline is stronger/thicker, which looks better in the bars

Here are two sets of screenshots (you can probably ignore the Pixie closeups; they were mostly for me to measure and double-check and are here for completeness, as I think the main screenshots adequately illustrate points 1 and 2).

Main screenshots:
(For bars, "existing" is the current icon and without a fixed nib; "fixed" has both the nibs fixed, as well as the two icon choices, "new" = attachment 394443 [details] and "72" = the current icon with its dpi reset to 72 px/in.)

http://www.ardisson.org/smokey/moz/sb-icon/malware-existing.png
http://www.ardisson.org/smokey/moz/sb-icon/malware-nightly-fixed-newicon.png
http://www.ardisson.org/smokey/moz/sb-icon/malware-nightly-fixed-72icon.png

http://www.ardisson.org/smokey/moz/sb-icon/popup-existing.png
http://www.ardisson.org/smokey/moz/sb-icon/popup-nightly-fixed-newicon.png
http://www.ardisson.org/smokey/moz/sb-icon/popup-nightly-fixed-72icon.png

http://www.ardisson.org/smokey/moz/sb-icon/siteicon-existing.png
http://www.ardisson.org/smokey/moz/sb-icon/siteicon-newicon.png
http://www.ardisson.org/smokey/moz/sb-icon/siteicon-72icon.png

Pixie closeups:

http://www.ardisson.org/smokey/moz/sb-icon/malware-existing-closeup.png
http://www.ardisson.org/smokey/moz/sb-icon/malware-new-closeup.png
http://www.ardisson.org/smokey/moz/sb-icon/malware-72-closeup.png

http://www.ardisson.org/smokey/moz/sb-icon/popup-existing-closeup.png
http://www.ardisson.org/smokey/moz/sb-icon/popup-new-closeup.png
http://www.ardisson.org/smokey/moz/sb-icon/popup-72-closeup.png

http://www.ardisson.org/smokey/moz/sb-icon/siteicon-existing-closeup.png
http://www.ardisson.org/smokey/moz/sb-icon/siteicon-new-closeup.png
http://www.ardisson.org/smokey/moz/sb-icon/siteicon-72-closeup.png

http://www.ardisson.org/smokey/moz/sb-icon/siteicon-tab-existing-closeup.png
http://www.ardisson.org/smokey/moz/sb-icon/siteicon-tab-new-closeup.png
http://www.ardisson.org/smokey/moz/sb-icon/siteicon-tab-72-closeup.png

Comment 20

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: popup_blocked_icon.tiff - Hicks v1a

philippe, will you have a look at my dpi fix in this tiff and have a run with it and the updated PopupBlockView.nib?

Comment 21

[philippe (part-time)]

Comment on attachment 397188 [details]
popup_blocked_icon.tiff - Hicks v1a

(In reply to comment #19)
> (From update of attachment 394443 [details])
> I'd rather use Jon's icon with the dpi corrected, for two reasons:
> 
> 1) The shadow is stronger/darker, which helps in the location bar
> 2) The white outline is stronger/thicker, which looks better in the bars
> 

I'm not so sure about your point 1).
The darker shadow helps more in the warning bars (esp the malware one; in the popup blocker bar it is barely visible anyway). In the location bar it looks quite heavy.

But r=me ; the resolution fix doesn't create problems otherwise.

Comment 22

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 397188 [details]
popup_blocked_icon.tiff - Hicks v1a

> I'm not so sure about your point 1).
> In the location bar it looks
> quite heavy.

I can see that argument, certainly ;-)  However, I think that it gives the icon (particularly the outer white line) more definition in the location bar case, whereas your new icon doesn't have as strong a shadow (it has a smoother, more subtle gradient), so your icon tended to "disappear" into the white of the bar more.  

If we were farther from release or overhauling the icon, I'd have us continue to play with the shadow to meet in the middle, but given the constraints (and the fact we still have bug 503816 we're playing with), I like the darker shadow and the stronger outer white lines better.

Comment 23

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 396549 [details]
Updated PopupBlockView.nib

This just has the same changes I made earlier to the safebrowsing bar to resize the image and turn off scaling.

Comment 24

[Stuart Morgan]

Comment on attachment 396549 [details]
Updated PopupBlockView.nib

sr=smorgan

Comment 25

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on trunk and CAMINO_2_0_BRANCH.