509701 - Inconsistent show/hide behavior of mailnews location toolbar

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: General, defect)

Description

[rsx11m]

Since the 20090807 nightly build, an empty "grippy" may show up when the location toolbar is hidden, and inconsistently disappear and reappear. This toolbar is shared with the search toolbar when both are visible. In some cases, both the opened toolbar and a grippy may be visible:

(1) default - grippy visible for closed location toolbar
(2) open grippy, disappears, combined location/search bar
(3) View > Hide > Location bar, grippy disappears
(4) View > Hide > Search bar, toolbar disappears
(5) close and reopen mailnews window, grippy reappears
(6) View > Show > Location bar, toolbar reappears
(7) View > Show > Search bar, grippy remains visible
(8) click on grippy and it disappears

Last win32 nightly working fine is 20090806, where no grippy was shown when the location toolbar is hidden.

Comment 1

[rsx11m]

Attachment: Various stages of the location toolbar

These are screendumps showing stages (1), (2), (3), and (7).

Comment 2

[rsx11m]

Also reproduced with Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.3pre) Gecko/20090811 SeaMonkey/2.0b2pre nightly build, thus all platforms.

Comment 3

[Philip Chee]

Bug 506492 is in the right timeframe.

Comment 4

[Philip Chee]

goToggleLocationToolbar() and OnLocationToolbarAttrModified() probably need to be fixed. Collapsing the Location toolbar by clicking on the grippy moves the searchbar to the message pane.

Comment 5

[[e-mail]]

Attachment: I think this fixes things

* Changed from using "collapsed" to using "hidden"
* Was able to use goToggleToolbar and remove goToggleLocationToolbar
* Forced current column as hiding the toolbar confuses the tree selection

Comment 6

[Ian Neal]

Comment on attachment 394832 [details] [diff] [review]
I think this fixes things

There does not seem to be anything about migrating the collapsed to hidden state so on first start with this patch applied you still get the collapsed grippy state which you have to sort out, after that no issues.

Comment 7

[[e-mail]]

(In reply to comment #6)
> (From update of attachment 394832 [details] [diff] [review])
> There does not seem to be anything about migrating the collapsed to hidden
> state so on first start with this patch applied you still get the collapsed
> grippy state which you have to sort out, after that no issues.
Unfortunately due to bug 506492 we don't know why the toolbar is in the collapsed state; it could be that the user genuinely clicked the grippy.

Comment 8

[Ian Neal]

Well when I first start SM after applying the patch, the location toolbar is showing collapsed in the UI but the View->Show/Hide->Location Toolbar is unchecked so in that case surely we should be doing something to fix it up?

Comment 9

[[e-mail]]

(In reply to comment #8)
> Well when I first start SM after applying the patch, the location toolbar is
> showing collapsed in the UI but the View->Show/Hide->Location Toolbar is
> unchecked so in that case surely we should be doing something to fix it up?
I'm not sure what you're getting at here but maybe you mean that the checked state of the menu should be copied to to the hidden state of the toolbar? I wouldn't want to leave code for that in permanently though.

Comment 10

[Ian Neal]

(In reply to comment #9)
> (In reply to comment #8)
> > Well when I first start SM after applying the patch, the location toolbar is
> > showing collapsed in the UI but the View->Show/Hide->Location Toolbar is
> > unchecked so in that case surely we should be doing something to fix it up?
> I'm not sure what you're getting at here but maybe you mean that the checked
> state of the menu should be copied to to the hidden state of the toolbar? I
> wouldn't want to leave code for that in permanently though.
Yes, some sort of migration code. What is the window of where users would have been affected by this?

Comment 11

[[e-mail]]

Last 3 weeks or so, so anyone using nightlies since just after beta 1.

Comment 12

[Ian Neal]

(In reply to comment #11)
> Last 3 weeks or so, so anyone using nightlies since just after beta 1.

Okay, probably not worth doing anything then if we can get it in for beta 2.

Comment 13

[[e-mail]]

Pushed changeset 42bada3ecb39 to comm-central.