Closed Bug 509857 Opened 12 years ago Closed 12 years ago
get rid of LOCK
we shouldn't need this
I assume we do not need to keep JS_strtod or JS_dtostr. These are both declared JS_FRIEND_API and are not in jsapi.h or used by Mozilla outside the JS engine.
Assignee: general → jorendorff
Let's try to lose the FRIENDs -- can you ask the newsgroup again? It has spam now and may be even less useful in proving no one uses an old friend API but we have to try somehow to reach embedders. /be
Who would review this, I wonder?
Sorry, but this patch don't apply.
This applies cleanly to tracemonkey tip. If there's something else I should be targeting, I don't know what that is!
Jason, You need to use js_free() and js_malloc() in your patch.
I'll happily update it if there are any signs of life in this bug. Waldo, will you have a chance to look at this any time soon?
Yeah, I need to get to this. Look for this by end of day Monday at the latest.
Haven't started yet, will look at it over dinner -- hope to get this done tonight, but if my brain turns to mush (it's starting to curdle) I'll have to punt to tomorrow morning.
It looks like I don't need to make any changes here for js_free and js_malloc. (However, as a separate bug, jsdtoa.cpp should #define MALLOC js_malloc #define FREE js_free before #include-ing dtoa.c.)
Attachment #428883 - Flags: review?(jwalden+bmo) → review+
Does it mean now that we can use Runtime per thread without JS_THREADSAFE?
(In reply to comment #13) > Does it mean now that we can use Runtime per thread without JS_THREADSAFE? Yes.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.