509864 - [SUMO] tiki-admin_categories.php times out

Status: VERIFIED FIXED

(support.mozilla.org :: General, defect)

Description

[Vishal Kamdar [:vish_moz]]

Summary: [SUMO] 'Admin Category' under 'Waiting for review' section gives a blank page

Steps to reproduce:
1. log in to https://support-stage.mozilla.org with an Admin account
2. click on 'My Account' => https://support-stage.mozilla.org/tiki-user_preferences.php?locale=en-US
3. click on 'Edited articles ready for review' => https://support-stage.mozilla.org/tiki-browse_categories.php?locale=en-US&parentId=11
4. click on 'admin category' link which will take you to stage.mozilla.org/tiki-admin_categories.php?parentId=11

Comment 1

[Vishal Kamdar [:vish_moz]]

Correction, # 4 should be click on 'admin category' link which will take you to
https://support-stage.mozilla.org/tiki-admin_categories.php?parentId=11

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

GET /tiki-admin_categories.php?locale=en-US&parentId=11 HTTP/1.1

Host: support-stage.mozilla.org


<snip>...

Referer: https://support-stage.mozilla.org/tiki-browse_categories.php?locale=en-US&parentId=11

Pragma: no-cache

Cache-Control: no-cache



HTTP/1.x 500 Internal Server Error

Date: Wed, 12 Aug 2009 00:08:20 GMT

Server: Apache/2.2.3 (Red Hat)

X-Powered-By: PHP/5.2.9

Expires: Thu, 19 Nov 1981 08:52:00 GMT

Cache-Control: no-cache, pre-check=0, post-check=0

Pragma: no-cache

Content-Length: 0

Connection: close

Content-Type: text/html; charset=UTF-8

Comment 3

[Paul Craciunoiu [:paulc]]

Attachment: patch, v1

This times out. Local running time for me is about 28 seconds.
The main issue here is the ridiculous number of polls we have. If we disallow polls to be assigned categories (which I think is fine), I get a load time of about 4s. Still horrible, but much better.

Finally, by only listing pages (articles) when filtering, the page load time is reduced to 0.4s. I propose we don't show polls at all (why assign a category to polls?) and don't list pages unless filtering.

This patch does it, and also populates the search field, which was previously ignored.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

https://support-stage.mozilla.org/tiki-browse_categories.php?locale=en-US&parentId=1&deep=off&type might need a similar fix?

Comment 5

[Laura Thomson :laura]

Comment on attachment 393956 [details] [diff] [review]
patch, v1

Good work.

Comment 6

[Paul Craciunoiu [:paulc]]

r49778 / r49779

Comment 7

[Paul Craciunoiu [:paulc]]

Marc: I realize this is a SUMO-only problem, but in general it would be great if admin pages would come with limits and pagination. E.g. we have way too many polls to be listed in a single select through a smarty loop.

Comment 8

[Vishal Kamdar [:vish_moz]]

Verified, FIXED.

Comment 9

[Marc Laporte]

Paul: +1 

It's pretty rare that people hit these problems in admin pages. There is now a centralization pagination system, so just needs to be deployed.

Tks.

Comment 10

[Louis-Philippe Huberdeau]

Added pagination. Every list in that page will be limited to 50 records, so speed should not be as much of an issue.