don't clear GtkWidget pointer from MozContainer's GdkWindow

RESOLVED FIXED in mozilla1.9.3a1

Status

()

Core
Widget: Gtk
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: karlt, Assigned: karlt)

Tracking

Trunk
mozilla1.9.3a1
x86
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Created attachment 393985 [details] [diff] [review]
patch

Attachment 390626 [details] [diff] changed container nsWindows to reuse the GdkWindow from the MozContainer GtkWidget instead of creating another child GdkWindow.

When the container GtkWidget is unrealized its descendant GdkWindows are removed from the GtkWidget (because the hierarchy is destroyed) by setting the GdkWindow's pointer to the GtkWidget to NULL.

Previously nsWindow::OnContainerUnrealize() would remove the descendant GdkWindows and the GtkWidget would remove its own GdkWindow.

Now, when mGdkWindow belongs to a GtkWidget (no longer a child of the GtkWidget's GdkWindow), we should not set mGdkWindow's widget to NULL, but let the GtkWidget do that.

(The nsWindow can still set the "nsWindow" data on the MozContainer's GdkWindow because it is the nsWindow that set and uses this data.)
(Assignee)

Comment 1

8 years ago
This would also be resolved by attachment 409402 [details] [diff] [review].
Depends on: 522635
(Assignee)

Comment 2

8 years ago
Fixed in bug 522635.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
You need to log in before you can comment on or make changes to this bug.