Closed Bug 510136 Opened 10 years ago Closed 10 years ago

TM: side exits can get deallocated in LeaveTree but are still returned by ExecuteTree

Categories

(Core :: JavaScript Engine, defect, P1)

x86
macOS
defect

Tracking

()

RESOLVED FIXED
Tracking Status
status1.9.2 --- beta1-fixed

People

(Reporter: gal, Assigned: gal)

References

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file, 1 obsolete file)

No description provided.
Assignee: general → gal
Attached patch patch (obsolete) — Splinter Review
This patch removes prohibitFlush and instead checks whether any context is within an ExecuteTree by checking whether cx->interpState is NULL. If any context has interpState set, we just set needFlush, which will be hit next time we try to execute a trace.
Attached patch patchSplinter Review
Attachment #394197 - Attachment is obsolete: true
Attachment #394201 - Attachment is patch: true
Attachment #394201 - Attachment mime type: application/octet-stream → text/plain
Attachment #394201 - Flags: review?(jorendorff)
Blocks: 506117
The patch passes trace-test after I backed out 508051.
Sent to try-server.
Comment on attachment 394201 [details] [diff] [review]
patch

This is better anyway. Nice.
Attachment #394201 - Flags: review?(jorendorff) → review+
http://hg.mozilla.org/tracemonkey/rev/224eda14efc9
Flags: blocking1.9.2?
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/224eda14efc9
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Flags: blocking1.9.2? → blocking1.9.2+
Priority: -- → P1
You need to log in before you can comment on or make changes to this bug.