Emphasize matches in AwesomeComplete

ASSIGNED
Assigned to

Status

()

Toolkit
Form Manager
ASSIGNED
9 years ago
6 years ago

People

(Reporter: Mardak, Assigned: Mardak)

Tracking

Trunk
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

9 years ago
Created attachment 394233 [details]
sample match

Now that we match anywhere with bug 446247, it would be useful to emphasize the matches.
(Assignee)

Comment 1

9 years ago
Created attachment 394234 [details] [diff] [review]
idea against Minefield.app

Simple changes against a nightly build to get the location bar emphasis.
(Assignee)

Updated

9 years ago
Attachment #394234 - Attachment is patch: true
Attachment #394234 - Attachment mime type: application/octet-stream → text/plain
(Assignee)

Comment 2

9 years ago
Created attachment 394235 [details] [diff] [review]
v1

Convert the minefield.app patch into mozilla-central one
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attachment #394235 - Flags: review?(dolske)
(Assignee)

Comment 3

9 years ago
So attachment 394233 [details] shows without any extra styling, the font size gets bigger... probably related to the location bar bigger title. We'll probably want to keep the size the same and black as we do now.

Anything special for the emphasis part?
Keywords: uiwanted
>We'll probably want to keep the size the same and black as we do now.

Yep, I agree

>Anything special for the emphasis part?

Probably just bold and underlined for now.  We might also want to look into make the normal text slightly grey, and playing with kerning so the characters don't shift once they become bold, but those changes would impact the awesome bar as well as this interface so we can decouple them and worry about it in follow up bugs.
Attachment #394235 - Flags: review?(dolske) → review-
Comment on attachment 394235 [details] [diff] [review]
v1

Two style glitches: I think the font is slightly larger than it used to be, and at least on OS X there are faint horizontal grey lines between entries.

Using the richresult also seems to limit the drop down to a maximum number of entries (12?). We might want to do that anyway, although this means we'll need to look closely at what other things we're picking up as a result of this simple change.

But I do like the addition of the bolding to form autocomplete!
Keywords: uiwanted
You need to log in before you can comment on or make changes to this bug.