510168 - Emphasize matches in AwesomeComplete

Status: ASSIGNED

(Toolkit :: Form Manager, defect, P3)

Description

[Ed Lee :Mardak]

Attachment: sample match

Now that we match anywhere with bug 446247, it would be useful to emphasize the matches.

Comment 1

[Ed Lee :Mardak]

Attachment: idea against Minefield.app

Simple changes against a nightly build to get the location bar emphasis.

Comment 2

[Ed Lee :Mardak]

Attachment: v1

Convert the minefield.app patch into mozilla-central one

Comment 3

[Ed Lee :Mardak]

So attachment 394233 [details] shows without any extra styling, the font size gets bigger... probably related to the location bar bigger title. We'll probably want to keep the size the same and black as we do now.

Anything special for the emphasis part?

Comment 4

[Alex Faaborg [:faaborg] (Firefox UX)]

>We'll probably want to keep the size the same and black as we do now.

Yep, I agree

>Anything special for the emphasis part?

Probably just bold and underlined for now.  We might also want to look into make the normal text slightly grey, and playing with kerning so the characters don't shift once they become bold, but those changes would impact the awesome bar as well as this interface so we can decouple them and worry about it in follow up bugs.

Comment 5

[Justin Dolske [:Dolske]]

Comment on attachment 394235 [details] [diff] [review]
v1

Two style glitches: I think the font is slightly larger than it used to be, and at least on OS X there are faint horizontal grey lines between entries.

Using the richresult also seems to limit the drop down to a maximum number of entries (12?). We might want to do that anyway, although this means we'll need to look closely at what other things we're picking up as a result of this simple change.

But I do like the addition of the bolding to form autocomplete!