510214 - Add a push group before drawing svg content

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

We currently spend a lot of time transferring data between us and the kernel when drawing svg. The attached patch fixes this by doing a push group before drawing. This lets us draw to a dibsection instead of a ddb and avoids the unnecessary data transfer.

Comment 1

[Jonathan Watt [:jwatt]]

Sounds great Jeff, but the attached patch seems to be invisible. :-) Can you attach it again?

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Attachment: Push group so that we have a dibsection

We might want to avoid pushing if we already have a client side surface...

Comment 3

[Jeff Muizelaar [:jrmuizel]]

One problem with this approach is that now we are drawing svg to a transparent surface and so we break cleartype text. See bug 363861.

Comment 4

[Jonathan Watt [:jwatt]]

Given all the graphics changes in the last year, is this bug still valid, Jeff?

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Nope, now that we do all of our drawing to skia surfaces this no longer applies