pork/porky/elsa build system fixes

RESOLVED FIXED

Status

()

Core
Rewriting and Analysis
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: cjones, Assigned: cjones)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Grab bag of

 * |pork/$ make clean| results in an error in elsa; "outdir doesn't exist"
 * |pork/$ make clean| blows away the configurations for pork and porky, probably not what's wanted
 * it'd be nice to have a |pork/$ make distclean| that *does* blow away configs for pork, porky, elsa et al.

Additionally I wanted to make elsa et al. build with the same flags as pork, but the sm_config build system tries to hard to prevent users from specifiying CXXFLAGs.  Rather than fix a pile of Perl crud, I'd rather just rewrite the whole shebang in Scons or something like that.  pork could share that code too.

Updated

9 years ago
Attachment #394332 - Flags: review?(tglek) → review+

Comment 3

9 years ago
Comment on attachment 394334 [details] [diff] [review]
elsa bugfix

> clean:
> 	rm -f $(TOCLEAN) gmon.out
>-	cd outdir && ls | grep -v CVS | xargs rm -f
>+	if [ -d outdir ]; then (cd outdir && ls | grep -v CVS | xargs rm -f); fi

you can't seriously expect an r+ for something that is still looking for CVS dirs :)

r+ conditional on getting rid of that grep.
Attachment #394334 - Flags: review?(tglek) → review+
You need to log in before you can comment on or make changes to this bug.