Closed
Bug 510285
Opened 15 years ago
Closed 15 years ago
pork/porky/elsa build system fixes
Categories
(Developer Infrastructure :: Source Code Analysis, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: cjones, Assigned: cjones)
Details
Attachments
(2 files)
3.65 KB,
patch
|
taras.mozilla
:
review+
|
Details | Diff | Splinter Review |
543 bytes,
patch
|
taras.mozilla
:
review+
|
Details | Diff | Splinter Review |
Grab bag of * |pork/$ make clean| results in an error in elsa; "outdir doesn't exist" * |pork/$ make clean| blows away the configurations for pork and porky, probably not what's wanted * it'd be nice to have a |pork/$ make distclean| that *does* blow away configs for pork, porky, elsa et al. Additionally I wanted to make elsa et al. build with the same flags as pork, but the sm_config build system tries to hard to prevent users from specifiying CXXFLAGs. Rather than fix a pile of Perl crud, I'd rather just rewrite the whole shebang in Scons or something like that. pork could share that code too.
Assignee | ||
Comment 1•15 years ago
|
||
Attachment #394332 -
Flags: review?(tglek)
Assignee | ||
Comment 2•15 years ago
|
||
Attachment #394334 -
Flags: review?(tglek)
Updated•15 years ago
|
Attachment #394332 -
Flags: review?(tglek) → review+
Comment 3•15 years ago
|
||
Comment on attachment 394334 [details] [diff] [review] elsa bugfix > clean: > rm -f $(TOCLEAN) gmon.out >- cd outdir && ls | grep -v CVS | xargs rm -f >+ if [ -d outdir ]; then (cd outdir && ls | grep -v CVS | xargs rm -f); fi you can't seriously expect an r+ for something that is still looking for CVS dirs :) r+ conditional on getting rid of that grep.
Attachment #394334 -
Flags: review?(tglek) → review+
Assignee | ||
Comment 4•15 years ago
|
||
Pushed http://hg.mozilla.org/rewriting-and-analysis/elsa/rev/9a4a55f21304 Pushed http://hg.mozilla.org/rewriting-and-analysis/pork/rev/8d5306d66edc
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Core → Firefox Build System
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•