510285 - pork/porky/elsa build system fixes

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Grab bag of

 * |pork/$ make clean| results in an error in elsa; "outdir doesn't exist"
 * |pork/$ make clean| blows away the configurations for pork and porky, probably not what's wanted
 * it'd be nice to have a |pork/$ make distclean| that *does* blow away configs for pork, porky, elsa et al.

Additionally I wanted to make elsa et al. build with the same flags as pork, but the sm_config build system tries to hard to prevent users from specifiying CXXFLAGs.  Rather than fix a pile of Perl crud, I'd rather just rewrite the whole shebang in Scons or something like that.  pork could share that code too.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: pork changes

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: elsa bugfix

Comment 3

[(dormant account)]

Comment on attachment 394334 [details] [diff] [review]
elsa bugfix

> clean:
> 	rm -f $(TOCLEAN) gmon.out
>-	cd outdir && ls | grep -v CVS | xargs rm -f
>+	if [ -d outdir ]; then (cd outdir && ls | grep -v CVS | xargs rm -f); fi

you can't seriously expect an r+ for something that is still looking for CVS dirs :)

r+ conditional on getting rid of that grep.

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Pushed http://hg.mozilla.org/rewriting-and-analysis/elsa/rev/9a4a55f21304
Pushed http://hg.mozilla.org/rewriting-and-analysis/pork/rev/8d5306d66edc