Closed
Bug 510325
Opened 15 years ago
Closed 15 years ago
update fennecmark as old version is broken with tile merge
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jmaher, Assigned: jmaher)
References
Details
Attachments
(3 files, 1 obsolete file)
4.24 KB,
patch
|
taras.mozilla
:
review+
|
Details | Diff | Splinter Review |
3.05 KB,
patch
|
anodelman
:
review+
|
Details | Diff | Splinter Review |
559 bytes,
patch
|
taras.mozilla
:
review+
|
Details | Diff | Splinter Review |
Comment 2•15 years ago
|
||
This is my attempt at merging, which was pretty much me dumping Taras' js into the tree. At second glance it looks like Joel made changes which I overwrote, but I'm not sure what changes we need to keep. http://hg.mozilla.org/users/asasaki_mozilla.com/talos-maemo/rev/1008d7631c94 Currently Fennecmark is timing out afaict.
Assignee | ||
Comment 3•15 years ago
|
||
I am at a loss here. I have over 6 hours in trying to get the new fennecmark working. While looking in the js error console, I see: Error: invalid label Source File: chrome://fennecbench/content/pageload.js Line: 35 browser.loadURI("http://www.yahoo.com", null, null, false); Error: LagDuringLoad is not defined Source File: chrome://fennecbench/content/overlay.js Line: 3 Then while clicking on the overlay image, I see this: Error: BenchFE is undefined Source File: chrome://browser/content/browser.xul Line: 1 Not sure how to work around this. If somebody can give me some pointers, I would appreciate it.
Assignee | ||
Comment 4•15 years ago
|
||
this diff file is a patch for: http://hg.mozilla.org/users/tglek_mozilla.com/fennecmark This patch adds in the extra talos stuff and when called via the event listener it sets the talos flag in BenchFE and report so the addtional talos magic happens (including loading the localhost page). I have testing this as a .jar file with talos and standalone for linux desktop and it works as expected. What is missing from this patch to run on talos is the fennecmark.html file which is a small file which triggers the event to start talos. There is a Makefile (usage: make all) which zip's up the bits and creates a fennecbench.jar file. taras, if you could review this patch and integrate it into your repository, we can then start using this on the maemo talos again.
Attachment #408107 -
Flags: review?(tglek)
Comment 5•15 years ago
|
||
Comment on attachment 408107 [details] [diff] [review] updated tpan not sure why you need parseInt, but that wont hurt.
Attachment #408107 -
Flags: review?(tglek) → review+
Assignee | ||
Comment 6•15 years ago
|
||
Taras, could you apply the patch to your repo: http://hg.mozilla.org/users/tglek_mozilla.com/fennecmark
Comment 7•15 years ago
|
||
http://hg.mozilla.org/users/tglek_mozilla.com/fennecmark/rev/8cfdb627cca0
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 8•15 years ago
|
||
Aki: please add fennecmark.html to the talos cvs repository. This will drive fennecmark. According to the mobile.config in cvs, it is referencing tpan/fennecmark.html for tpan and tzoom, so we can put it there and not have to edit anything else.
Updated•15 years ago
|
Attachment #408846 -
Flags: review?(anodelman)
Comment 9•15 years ago
|
||
Comment on attachment 408846 [details]
fennecmark driver for talos
this would go in tpan/fennecmark.html
Comment 10•15 years ago
|
||
Aha, cvs diff -N includes the html file =)
Attachment #408846 -
Attachment is obsolete: true
Attachment #409213 -
Flags: review?(anodelman)
Attachment #408846 -
Flags: review?(anodelman)
Updated•15 years ago
|
Attachment #409213 -
Flags: review?(anodelman) → review+
Comment 11•15 years ago
|
||
Comment on attachment 409213 [details] [diff] [review] mobile.config update to put fennecmark.html in talos/startup_test/ Checking in mobile.config; /cvsroot/mozilla/testing/performance/talos/mobile.config,v <-- mobile.config new revision: 1.2; previous revision: 1.1 done RCS file: /cvsroot/mozilla/testing/performance/talos/startup_test/fennecmark.html,v done Checking in startup_test/fennecmark.html; /cvsroot/mozilla/testing/performance/talos/startup_test/fennecmark.html,v <-- fennecmark.html initial revision: 1.1 done
Assignee | ||
Comment 12•15 years ago
|
||
Forgot to hg add Makefile and fennecbench.manifest. Makefile will create the .jar file and fennecbench.manifest is needed in the chrome directory with the .jar file.
Attachment #410704 -
Flags: review?(tglek)
Updated•15 years ago
|
Attachment #410704 -
Flags: review?(tglek) → review+
Comment 13•15 years ago
|
||
Comment on attachment 410704 [details] [diff] [review] makefile and manifest patch I've pushed this; thanks Joel and Taras!
You need to log in
before you can comment on or make changes to this bug.
Description
•