510391 - xpinstall code coverage runs should not have low coverage.

Status: RESOLVED FIXED

(Testing :: Code Coverage, defect)

Description

[Murali Nandigama [:murali]]

xpinstall component code coverage runs should not have that low coverage. Needs investigation from the logs at http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/experimental/codecoverage/codecoverage-mozilla-central-logs.tar

Please help investigate

Comment 1

[Dave Townsend [:mossop]]

Can't do anything here without working logs.

Comment 2

[Murali Nandigama [:murali]]

I have a work around to get the issue work for you.

please use the following command 

bzip2 -c -d mochitest-browser-chrome.bz2 |tee browser-chrome.log

That should get you the required info printed out to the STDOUT and then 'tee'ed into the log file.

Comment 3

[Dave Townsend [:mossop]]

Attachment: Running tests

Based on the output from that we are only running about half of the browser chrome tests. Attached is a list of those that run, that is 109 out of the full set of 195

There is no indication why the test run stopped (presumably because we don't actually have the full log here) but the log is filled with thousands of the following error assertion:

JavaScript error: chrome://mochikit/content/browser-test.js, line 89: testMessage is not defined
###!!! ASSERTION: XPConnect is being called on a scope without a 'Components' property!: 'Error', file /builds/moz2_slave/mozilla-central-linux-codecoverage/build/js/src/xpconnect/src/xpcwrappednativescope.cpp, line 786
DEBUG_CheckForComponentsInScope(JSContext*, JSObject*, int, XPCJSRuntime*) (/builds/moz2_slave/mozilla-central-linux-codecoverage/build/js/src/xpconnect/src/xpcwrappednativescope.cpp:786)
XPCWrappedNativeScope::FindInJSObjectScope(JSContext*, JSObject*, int, XPCJSRuntime*) (/builds/moz2_slave/mozilla-central-linux-codecoverage/build/js/src/xpconnect/src/xpcwrappednativescope.cpp:843)
XPCWrappedNativeScope::FindInJSObjectScope(XPCCallContext&, JSObject*, int) (/builds/moz2_slave/mozilla-central-linux-codecoverage/build/js/src/xpconnect/src/xpcprivate.h:1417)
GetContextFromObject (/builds/moz2_slave/mozilla-central-linux-codecoverage/build/js/src/xpconnect/src/xpcwrappedjsclass.cpp:566)
nsXPCWrappedJSClass::CallMethod(nsXPCWrappedJS*, unsigned short, XPTMethodDescriptor const*, nsXPTCMiniVariant*) (/builds/moz2_slave/mozilla-central-linux-codecoverage/build/js/src/xpconnect/src/xpcwrappedjsclass.cpp:1282)
nsXPCWrappedJS::CallMethod(unsigned short, XPTMethodDescriptor const*, nsXPTCMiniVariant*) (/builds/moz2_slave/mozilla-central-linux-codecoverage/build/js/src/xpconnect/src/xpcwrappedjs.cpp:570)
PrepareAndDispatch (/builds/moz2_slave/mozilla-central-linux-codecoverage/build/xpcom/reflect/xptcall/src/md/unix/xptcstubs_gcc_x86_unix.cpp:95)
NS_InvokeByIndex_P (/builds/moz2_slave/mozilla-central-linux-codecoverage/build/objdir/dist/bin/libxpcom_core.so)
nsProxyObjectCallInfo::Run() (/builds/moz2_slave/mozilla-central-linux-codecoverage/build/xpcom/proxy/src/nsProxyEvent.cpp:181)
nsThread::ProcessNextEvent(int, int*) (/builds/moz2_slave/mozilla-central-linux-codecoverage/build/xpcom/threads/nsThread.cpp:527)
NS_ProcessNextEvent_P(nsIThread*, int) (/builds/moz2_slave/mozilla-central-linux-codecoverage/build/objdir/xpcom/build/nsThreadUtils.cpp:230)
nsBaseAppShell::Run() (/builds/moz2_slave/mozilla-central-linux-codecoverage/build/widget/src/xpwidgets/nsBaseAppShell.cpp:169)
nsAppStartup::Run() (/builds/moz2_slave/mozilla-central-linux-codecoverage/build/toolkit/components/startup/src/nsAppStartup.cpp:193)
XRE_main (/builds/moz2_slave/mozilla-central-linux-codecoverage/build/toolkit/xre/nsAppRunner.cpp:3392)
main (/builds/moz2_slave/mozilla-central-linux-codecoverage/build/browser/app/nsBrowserApp.cpp:156)
__libc_start_main (/usr/src/debug/glibc-2.5-20061008T1257/csu/libc-start.c:262)

Comment 4

[Dave Townsend [:mossop]]

Going to tentatively call this fixed, I'm now seeing 87% line coverage and bar one oddity the only lines not covered are those that I wouldn't expect to be covered since they are edge cases where the system runs out of memory etc. that we cannot really test automatically.