Closed
Bug 510417
Opened 15 years ago
Closed 15 years ago
Implement new planet.mozilla.org theme to match new mozilla.org theme
Categories
(Websites :: planet.mozilla.org, defect)
Websites
planet.mozilla.org
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: samuel.sidler+old, Assigned: samuel.sidler+old)
References
()
Details
Attachments
(2 files, 3 obsolete files)
268.19 KB,
application/zip
|
Details | |
19.70 KB,
patch
|
reed
:
review+
|
Details | Diff | Splinter Review |
As we're finalizing the new mozilla.org theme (planning to go live in a week and a half), I'd like to create a new theme for planet.mozilla.org. I've attached a rough mockup to work from and would like sign off before I start coding anything. Some of this (font sizes, feed stuff in the sidebar) are subject to minor change, but this is a rough mockup. I've tried to minimize the size of the header in this version, as opposed to mozilla.org. The links in the header will get replaced by those on www-stage.mozilla.org now (replacing "Blogs" with "mozilla.org"). Asa / Deb: Care to sign off before I start?
Attachment #394449 -
Flags: review?(asa)
Assignee | ||
Updated•15 years ago
|
Attachment #394449 -
Flags: review?(deb)
Comment 1•15 years ago
|
||
a=asa!!!
Comment 2•15 years ago
|
||
This is awesome. a = dria.
Assignee | ||
Comment 3•15 years ago
|
||
Comment on attachment 394449 [details]
Mockup v1
We'll call both of those "r+" and I'll get started. Hoping to have something ready before we go live with the new mozilla.org
Attachment #394449 -
Flags: review?(deb)
Attachment #394449 -
Flags: review?(asa)
Updated•15 years ago
|
Attachment #394449 -
Flags: review+
Assignee | ||
Comment 4•15 years ago
|
||
Taking this bug then... I should have something in a week or so, then I'll assign it to someone else to check-in, since I can't.
Assignee: asa → samuel.sidler
Comment 5•15 years ago
|
||
Awesome! I'd be glad to check-in when you're ready.
Comment 6•15 years ago
|
||
Thinking we could lump bug 506105 into this. Thoughts?
Assignee | ||
Comment 7•15 years ago
|
||
I'll be removing that release schedule info completely and instead making a link to wikimo/Releases.
Comment 8•15 years ago
|
||
sounds good to me.
Assignee | ||
Comment 9•15 years ago
|
||
Here's what I'm thinking for the footer. Since Planet Mozilla doesn't have a full footer like mozilla.org does, it doesn't make sense to transpose the entire footer to Planet. I think this gets the spirit of the theme though. Let me know if you have comments.
Comment 10•15 years ago
|
||
That makes me wonder if we should revisit bug 376873... a disclaimer since it's not official content in any way.
Assignee | ||
Comment 11•15 years ago
|
||
Probably not going to get much further today, but in the interest of buses... changing the URL to my current WIP and all its problems. If you want to fix bug 376873, let me know what text you want and where you want it. I can include that pretty easily.
Comment 12•15 years ago
|
||
I doubt if we're fixing that bug we'll have wordage asap... Can we perhaps come up with something design wise and just comment it out? Looks great btw.
Comment 13•15 years ago
|
||
The whole design looks great. For comment #9 about the footer, a scaled down footer makes sense, although are there some Planet related links we could put down there? Maybe a list of other Planets in the community? http://education.mozilla.org/planet/ http://planet.mozillamessaging.com/ others...
Assignee | ||
Comment 14•15 years ago
|
||
We currently put other planets (or one of them at least) in the top right on the page ("Planet Mozilla Interns"). I think it's better to have them at the top than in the footer.
Comment 15•15 years ago
|
||
Sure, putting them at the top of the page instead of the footer makes sense -- either way it would be nice to have a full list of available community planets.
Comment 16•15 years ago
|
||
>there some Planet related links we could put >down there? Maybe a list of other Planets in the community? > >http://education.mozilla.org/planet/ >http://planet.mozillamessaging.com/ >others... As kind of the inverse, I filed the meta bug 511001 to track getting all the various sub planets to link up to the higher level planets. The general idea being that these sub planets are really great, but we should give users the ability to navigate up to the broader feeds of information as well, so that we don't create a bunch of unlinked isolated islands of information.
Assignee | ||
Comment 17•15 years ago
|
||
Alright, I've updated my staging site[1] with what I have so far. I consider this "complete". The quotes are because I haven't tested IE at all. But this works in the latest Firefox 3.5 and Safari 4 releases. Before I start making this apply to the actual planet code base (create a theme for planet.mozilla.org to use) and cleaning up the CSS code, can I get sign off from a peer/owner? [1] http://people.mozilla.org/~ss/planet-redesign/
Comment 18•15 years ago
|
||
I'm not the project owner, obviously, but wanted to chime in and say that this looks awesome. Can't wait for it to go live!
Comment 19•15 years ago
|
||
I love it! A major improvement. Should get some other planet folks feedback of course. ;-) My only thought is that perhaps there needs to be some more thought given to headers in blog posts. In particular the relationship between post title, blog name, and headers within a blog post. Reason being that post title and blog name blend slightly, though I'm totally cool with that... but if a blog post happens to contain a header tag (example: h3)... that's where I think it might be worth examining. FWIW planet currently sucks at this currently. It's not a new issue. I should be clear about that. I wouldn't even call it a blocker. Just a "that would be awesome to fix" kinda thing. Thinking the best approach would be perhaps have a completely different set of font sizes for header tags in .entry. I think planet has the ability to normalize header tags.. Perhaps Phil Ringnalda could chime in here. That would obviously help. That's really my only thought. Sorry for not bringing that up earlier. I've thought it for some time, though I didn't even think about it in terms of this new theme until I was comparing it with the live version. That said... sooner we can roll this the better. It looks awesome.
Comment 20•15 years ago
|
||
A few examples of blog posts with header tags that I see on planet right now.
Assignee | ||
Comment 21•15 years ago
|
||
I'll see what I can do, but it might be better to fix that post-launch. It'll add a bunch of complication to my current stuff, I think. (Complication worth having, mind you, but I don't think it's worth blocking on.)
Comment 22•15 years ago
|
||
Look's great. mpa=reed (In reply to comment #19) > I think planet has the ability to normalize header tags.. Perhaps Phil > Ringnalda could chime in here. That would obviously help. I'm not Phil, but yes, we can normalize header tags. We actually run everything on pmo through the minhead.py filter currently.
Comment 23•15 years ago
|
||
Agreed. Lets not block. It's a nice to have, but not a requirement. Especially considering we don't currently have it. Fixing it would be awesome from a readability perspective, especially if we can normalize header tags.
Comment 24•15 years ago
|
||
It looks great. Just a couple minor things (not worth blocking on, but still worth mentioning since I get to use the word 'snout' in a bug): * Is part of the dino's snout cut off? It looks like the image just stops right around the 'll' in mozilla. * There's a bit of a gap to the right of 'Looking for' in the very top that's not on the original design.
Comment 25•15 years ago
|
||
(In reply to comment #17) > Before I start making this apply to the actual planet code base (create a theme > for planet.mozilla.org to use) and cleaning up the CSS code, can I get sign off > from a peer/owner? > > [1] http://people.mozilla.org/~ss/planet-redesign/ a=asa
Assignee | ||
Comment 26•15 years ago
|
||
(In reply to comment #24) > * Is part of the dino's snout cut off? It looks like the image just stops > right around the 'll' in mozilla. Fixed. > * There's a bit of a gap to the right of 'Looking for' in the very top that's > not on the original design. Fixed.
Comment 27•15 years ago
|
||
Looks good to me. This is great :)
Assignee | ||
Comment 28•15 years ago
|
||
(In reply to comment #17) > The quotes are because I haven't tested IE at all. Turns out this looks perfectly fine in IE8 and mostly fine (some spacing issues in the sidebar) using compatibility mode, which I assume is IE7-equivalent. Do we care at all about IE6? How about old Safaris (3 or less) and Firefoxes (2 or less)?
Assignee | ||
Comment 29•15 years ago
|
||
faaborg noticed that the "planet mozilla" text is a bit too sharp. I wanted to fix that but I didn't bring Photoshop with me so I won't be able to. If someone else wants to take that on (including the shading), feel free, otherwise I'll fix it sometime in October.
Assignee | ||
Comment 30•15 years ago
|
||
Assignee | ||
Comment 31•15 years ago
|
||
There's probably a bunch of clean-up work that can be done here, but ship early, ship often, right? We can always fix things later. One thing I wanted to do but didn't was put images in the /img/ directory. I didn't do it because I'm not really sure if adding them to config.ini would work. So, here we are. Images will be in the root directory. Tagging Robert for review, but anyone else can feel free to jump in, I'm sure. I don't know if this needs a *lot* of review, just a quick once-over should be fine. Again, we can iterate as we need to.
Attachment #394449 -
Attachment is obsolete: true
Attachment #394686 -
Attachment is obsolete: true
Attachment #397194 -
Attachment is obsolete: true
Attachment #398345 -
Flags: review?(robert)
Assignee | ||
Comment 32•15 years ago
|
||
Oh, and in case it wasn't clear, the zip file needs to be extracted into the "theme" directory: http://svn.mozilla.org/projects/planet/branches/planet/theme/
Comment 33•15 years ago
|
||
Comment on attachment 398345 [details] [diff] [review] Patch v1 Initial read-through looks good... let's get this live. r=reed
Attachment #398345 -
Flags: review?(robert) → review+
Comment 34•15 years ago
|
||
r50826, thanks!
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Comment 35•15 years ago
|
||
I know this should be a separate bug but I don't have time to file one right now. The "Subscribe to Planet", "Other Planets", and "Subscriptions" column overlaps the text on the page on trunk.
You need to log in
before you can comment on or make changes to this bug.
Description
•