Closed Bug 510435 Opened 15 years ago Closed 15 years ago

Remove unused make variable DSO_LDFLAGS

Categories

(NSS :: Build, defect)

defect
Not set
trivial

Tracking

(Not tracked)

VERIFIED FIXED
3.12.5

People

(Reporter: wtc, Assigned: wtc)

Details

Attachments

(1 file)

As this MXR search shows: http://mxr.mozilla.org/security/search?string=DSO_LDFLAGS the make variable DSO_LDFLAGS is defined but not used. It should be removed. We are using DSO_LDOPTS now.
Assignee: nobody → wtc
Status: NEW → ASSIGNED
Target Milestone: --- → 3.12.5
Attached patch Proposed patchSplinter Review
Remove the unused make variable DSO_LDFLAGS.
Attachment #394511 - Flags: review?(christophe.ravel.bugs)
Comment on attachment 394511 [details] [diff] [review] Proposed patch r=christophe
Attachment #394511 - Flags: review?(christophe.ravel.bugs) → review+
I checked in the patch on the NSS trunk (NSS 3.12.5). Checking in BSD_OS.mk; /cvsroot/mozilla/security/coreconf/BSD_OS.mk,v <-- BSD_OS.mk new revision: 1.6; previous revision: 1.5 done Checking in BeOS.mk; /cvsroot/mozilla/security/coreconf/BeOS.mk,v <-- BeOS.mk new revision: 1.4; previous revision: 1.3 done Checking in HP-UX.mk; /cvsroot/mozilla/security/coreconf/HP-UX.mk,v <-- HP-UX.mk new revision: 1.15; previous revision: 1.14 done Checking in Linux.mk; /cvsroot/mozilla/security/coreconf/Linux.mk,v <-- Linux.mk new revision: 1.42; previous revision: 1.41 done Checking in NetBSD.mk; /cvsroot/mozilla/security/coreconf/NetBSD.mk,v <-- NetBSD.mk new revision: 1.7; previous revision: 1.6 done Checking in OpenBSD.mk; /cvsroot/mozilla/security/coreconf/OpenBSD.mk,v <-- OpenBSD.mk new revision: 1.7; previous revision: 1.6 done Checking in OpenUNIX.mk; /cvsroot/mozilla/security/coreconf/OpenUNIX.mk,v <-- OpenUNIX.mk new revision: 1.4; previous revision: 1.3 done Checking in QNX.mk; /cvsroot/mozilla/security/coreconf/QNX.mk,v <-- QNX.mk new revision: 1.4; previous revision: 1.3 done Checking in RISCOS.mk; /cvsroot/mozilla/security/coreconf/RISCOS.mk,v <-- RISCOS.mk new revision: 1.4; previous revision: 1.3 done Checking in SCO_SV3.2.mk; /cvsroot/mozilla/security/coreconf/SCO_SV3.2.mk,v <-- SCO_SV3.2.mk new revision: 1.5; previous revision: 1.4 done
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: