510527 - Failed releases are kicked back to user instead of going back to editor

Status: RESOLVED FIXED

(Websites Graveyard :: byob.mozilla.com, enhancement, P1)

Description

[Kev Needham [:kev]]

When repack generation fails (i.e. script bombs or some such), the release is kicked back to the user with instructions to re-try after a certain day/time. I think the proper step here is for the admins/editors to be notified of the failure so they're aware of what's going on, and to hold the build in the moderator queue (realize this may be more work, so need call on in scope or out) so the editors can retry the repack or do a root cause.

Sample repack with errors in the history is the "booyah" build:

http://dm-partnerdist01.mozilla.org:82/~lorchard/byob2/profiles/deadsquid/browsers/booyah

Let me know if further info is required to clarify.

thanks!

k

Comment 1

[Les Orchard [:lorchard]]

Yeah, this will take some reshuffling of the repack states, permissions, notifications, and associates tests.  It's doable, but might be worth deferring if there are other bugs to fix.

Also, what should the user see vs editor see when a build fails? Should a user just see that the build is still in progress, and only display the failure to editors?

Comment 2

[Kev Needham [:kev]]

Ok, let's defer pending any other bugs in the next few days, and I'll rewrite the message the user receives so it's clearer to them that they need to re-submit their release request.

My thought is that the user would just see that it's pending. Because there's no root-cause determination for why the build fails, I think it's better that the admins maintain ownership, especially if there's a system issue which affects multiple builds.

Comment 3

[Les Orchard [:lorchard]]

changing to enhancement for post-release milestones

Comment 4

[Les Orchard [:lorchard]]

Added time estimate to whiteboard

Comment 5

[Les Orchard [:lorchard]]

Pushing into my bug queue.

Comment 6

[Les Orchard [:lorchard]]

Time estimate tweak

Comment 7

[Les Orchard [:lorchard]]

r63156 introduces a 'see_failed' privilege for editors and admins, which normal users do not have. 

Without 'see_failed', the following applies:

* Failed builds will appear as if still builds in progress
* No notification will be sent to the owner on build failure
* No action buttons will be presented on repack detail / list pages
* Build failures will be omitted from the event history in repack details

This effectively squelches build failures to normal users, but admins/editors still get notifications and can see the results of the failure.