Closed
Bug 510568
Opened 16 years ago
Closed 16 years ago
Kill one last #if JS_HAS_LVALUE_RETURN directive
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jorendorff, Assigned: jorendorff)
References
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
826 bytes,
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
See bug 509098. This actually causes the parser to choke on x(y)=z and therefore causes some tests to fail.
|
Assignee | |
Comment 1•16 years ago
|
||
Assignee: general → jorendorff
Attachment #394553 -
Flags: review?(jwalden+bmo)
|
||
Updated•16 years ago
|
Attachment #394553 -
Flags: review?(jwalden+bmo) → review+
|
|
||
Comment 2•16 years ago
|
||
I should have grepped during review with patch applied, sorry.
/be
|
|
Assignee | |
Updated•16 years ago
|
Whiteboard: fi
|
|
Assignee | |
Comment 3•16 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/0709d3c94bfc
I think the patch you reviewed was fine, because I remember running it through js/tests and getting only acceptable new failures.
It must have been an error rebasing or rejects produced by qpush. Anyway, this was among about a dozen silly mistakes I made on August 13, aka Goofball Thursday. Sorry!
Whiteboard: fi → fixed-in-tracemonkey
|
||
Comment 4•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•