510581 - setState doesn't seem to persist for geolocation tests

Status: NEW

(Testing :: General, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

In our geolocation tests we were using the setState and getState to control various aspects of our tests.  The one test that used this was getting random Orange and it looks like removing the calls to setState/getState fix this.

So we either need to fix these calls, or fix other tests which utilize these calls.  Here is a list that I found in mxr:
http://mxr.mozilla.org/mozilla-central/source/content/base/test/file_CrossSiteXHR_cache_server.sjs
http://mxr.mozilla.org/mozilla-central/source/dom/src/threads/test/closeOnGC_server.sjs
http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/ajax/offline/obsoletingManifest.sjs (and about 6 other .sjs files in the same directory)
http://mxr.mozilla.org/mozilla-central/source/modules/libpr0n/test/mochitest/bug490949.sjs

Comment 1

[Jeff Walden [:Waldo]]

Which particular tests are randomly failing?  I will all but guarantee the problem is not with the API or its implementation but rather with how its users are using it.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Here is the .sjs file that uses setState and getState:
http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/geolocation/network_geolocation.sjs

Here is the test that uses it:
http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/geolocation/test_timeoutWatch.html?force=1

it is actually done via an api in this file:
http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/geolocation/geolocation_common.js


Hopefully there is something wrong with the way we are using it.