Closed Bug 510602 Opened 15 years ago Closed 15 years ago

NJ merge: massage LIR opcodes to merge state

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
status1.9.2 --- beta1-fixed

People

(Reporter: graydon, Assigned: graydon)

References

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file, 1 obsolete file)

rebase and adjust
21.83 KB, patch
dvander
: review+
Details | Diff | Splinter Review
Attached patch Opcode adjustments all over (obsolete) — — Splinter Review 
An attempt at making the LIR opcodes line up with Tamarin (and with the names and meanings given in the merged opcode assignment table:

http://developer.mozilla.org/En/NanojitMerge#LIR_opcode_assignments

Appears to mostly work, though there's an earlier regression on ARM from some other patch this week masking my efforts to confirm there. Hunting presently.
Attachment #394586 - Flags: review?(gal)
Comment on attachment 394586 [details] [diff] [review]
Opcode adjustments all over

This is going to break Sparc. Please cc Leon from Sun.
Attachment #394586 - Flags: review?(gal) → review+
Dvander has been pulling code in from TR as necessary for his x64 work, and so some of this patch was redundant. Re-posting the residual and requesting his review. Don't want to step on any toes.
Attachment #394586 - Attachment is obsolete: true
Attachment #397167 - Flags: review?(dvander)
Comment on attachment 397167 [details] [diff] [review]
rebase and adjust

Yay.
Attachment #397167 - Flags: review?(dvander) → review+
http://hg.mozilla.org/tracemonkey/rev/781eb6d940de
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/781eb6d940de
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: