Closed Bug 510630 Opened 11 years ago Closed 11 years ago

toolbar scrollable when awesome bar is displayed

Categories

(Firefox for Android Graveyard :: General, defect)

x86
Linux
defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: geoff, Assigned: vingtetun)

References

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.13) Gecko/2009080317 Fedora/3.0.13-1.fc10 Firefox/3.0.13
Build Identifier: 

If you go to the top of a page, and click on the urlbar to bring up the awesome bar list, you can then scroll the toolbar by clicking and dragging on its background. This reveals the top of the web page.


Reproducible: Always



Expected Results:  
Toolbar will be fixed in place while the awesome bar is visible.
Attached patch Patch v0.1Splinter Review
This patch lock the urlbar into position: fixed mode when a dialog is displayed.
Attachment #394608 - Flags: review?(mark.finkle)
Status: UNCONFIRMED → NEW
Ever confirmed: true
I don't particularly understand this patch.  I don't think we should be flagging our toolbars as dialogs -- can you explain what this patch is supposed to do?
(In reply to comment #2)
> I don't particularly understand this patch.  I don't think we should be
> flagging our toolbars as dialogs -- can you explain what this patch is supposed
> to do?

I have not added a flag, I reused a previously existing one for displaying the little top right corner icon to close a dialog, for example when a dialog is opened, e.g the awesome bar, or the bookmark popup (opened via the yellow star), the toolbar is flagged as 'dialog'.
(So, I move the flag one level in the DOM hierarchy to fit my needs.)

What I mean by fixing the position is: if we are in 'dialog' mode, we want the urlbar to be: 
 - fully visible (correct the half showing bug - (pan up && Ctrl+L) )
 - unmovable (correct this bug for all dialogs not only the awesome bar dialog)
Attachment #394608 - Flags: review?(mark.finkle) → review+
hmm, I do still notice an issue with this patch:

* If you display the awesomebar, the toolbar is _not_ panned when dragging on the toolbar background. However, the underlying surface is panned.

If you attempt to drag the toolbar, then press "esc" to close the awesomebar, you'll notice that the surface was panned.

Not sure if we want to try and fix it now, or as a followup bug.

It would be nice to _not_ pan the toolbar when displaying the awesomebar in beta3
(In reply to comment #4)
> hmm, I do still notice an issue with this patch:
> 
> * If you display the awesomebar, the toolbar is _not_ panned when dragging on
> the toolbar background. However, the underlying surface is panned.
> 
> If you attempt to drag the toolbar, then press "esc" to close the awesomebar,
> you'll notice that the surface was panned.

my bad, I've not think of that...

> 
> Not sure if we want to try and fix it now, or as a followup bug.
> 
> It would be nice to _not_ pan the toolbar when displaying the awesomebar in
> beta3
fixed by bug 510998
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
verified FIXED On builds:

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.2b1pre) Gecko/20091002
Fennec/1.0b4

and

Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2b1pre) Gecko/200910002
Fennec/1.0b4
Status: RESOLVED → VERIFIED
bugspam
Assignee: nobody → 21
You need to log in before you can comment on or make changes to this bug.