Closed
Bug 510650
Opened 15 years ago
Closed 15 years ago
mingw compilation failure in widget/src/windows/WindowHook.h
Categories
(Core :: Widget: Win32, defect, P2)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| status1.9.2 | --- | beta1-fixed |
People
(Reporter: Mook, Unassigned)
References
Details
Attachments
(1 file)
|
449 bytes,
patch
|
jimm
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
bug 507736 added mozilla::widget::WindowHook (for Win32); this fixes compilation on mingw. friend nsWindow needs to refer to the global class, not mozilla::widget::nsWindow (which doesn't exist)
Attachment #394628 -
Flags: review?(jmathies)
|
||
Updated•15 years ago
|
Attachment #394628 -
Flags: review?(jmathies) → review+
|
|
||
Updated•15 years ago
|
Attachment #394628 -
Flags: superreview?(roc)
Attachment #394628 -
Flags: superreview?(roc) → superreview+
r/sr, build only change (doesn't need tests), windows only, tested on msvc8 + gcc. marking checkin-needed, thanks for the reviews, guys! :D
Keywords: checkin-needed
Pushed: http://hg.mozilla.org/mozilla-central/rev/38f64aaaa565 Bustage fix: http://hg.mozilla.org/mozilla-central/rev/d2b9effde892
Woops, that bustage fix wasn't for this bug.
|
||
Comment 4•15 years ago
|
||
Blocks a blocking bug (Windows 7 tab preview) amazingly enough, thus is a blocker itself.
Flags: blocking1.9.2+
|
||
Updated•15 years ago
|
Priority: -- → P2
|
||
Updated•15 years ago
|
Whiteboard: [c-n: m-1.9.2]
|
|
||
Updated•15 years ago
|
status1.9.2:
--- → beta1-fixed
|
|
||
Comment 5•15 years ago
|
||
pushed to 1.9.2: http://hg.mozilla.org/releases/mozilla-1.9.2/rev/cf64f16894b8
|
||
Updated•12 years ago
|
Whiteboard: [c-n: m-1.9.2]
You need to log in
before you can comment on or make changes to this bug.
Description
•