Closed Bug 510773 Opened 10 years ago Closed 10 years ago

Help Keys [cmd+?] for mac does not work in the pageInfo window

Categories

(SeaMonkey :: Page Info, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.0b2

People

(Reporter: stefanh, Assigned: stefanh)

Details

Attachments

(1 file)

While we have F1, we don't have the Cmd+? combo that mac users expect.
Attached patch Add key comboSplinter Review
Mac users have had F1 for years now, so I figured win/nix users can cope with Cmd+?.
Attachment #394713 - Flags: superreview?(neil)
Attachment #394713 - Flags: review?(mnyromyr)
Attachment #394713 - Flags: superreview?(neil) → superreview+
Comment on attachment 394713 [details] [diff] [review]
Add key combo

>     <key keycode="VK_ESCAPE"                       command="cmd_close"/>
>     <key key="."                 modifiers="meta"  command="cmd_close"/>
>     <key keycode="VK_F1"                           command="cmd_help"/>
>+    <key key="&openHelpMac.key;" modifiers="accel" command="cmd_help"/>
Nit: use modifiers="meta" like we do for the alternate close key.
This ? key doesn't work with a German keyboard under Linux; I need to test this with my German Mac keyboard.
(In reply to comment #3)
> This ? key doesn't work with a German keyboard under Linux

Forget this, it does.
Attachment #394713 - Flags: review?(mnyromyr) → review+
Landed with "meta": http://hg.mozilla.org/comm-central/rev/6c93daf47447
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.