Help Keys [cmd+?] for mac does not work in the pageInfo window

RESOLVED FIXED in seamonkey2.0b2

Status

SeaMonkey
Page Info
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: stefanh, Assigned: stefanh)

Tracking

Trunk
seamonkey2.0b2
x86
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

2.01 KB, patch
Karsten Düsterloh
: review+
neil@parkwaycc.co.uk
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

8 years ago
While we have F1, we don't have the Cmd+? combo that mac users expect.
(Assignee)

Comment 1

8 years ago
Created attachment 394713 [details] [diff] [review]
Add key combo

Mac users have had F1 for years now, so I figured win/nix users can cope with Cmd+?.
Attachment #394713 - Flags: superreview?(neil)
Attachment #394713 - Flags: review?(mnyromyr)

Updated

8 years ago
Attachment #394713 - Flags: superreview?(neil) → superreview+

Comment 2

8 years ago
Comment on attachment 394713 [details] [diff] [review]
Add key combo

>     <key keycode="VK_ESCAPE"                       command="cmd_close"/>
>     <key key="."                 modifiers="meta"  command="cmd_close"/>
>     <key keycode="VK_F1"                           command="cmd_help"/>
>+    <key key="&openHelpMac.key;" modifiers="accel" command="cmd_help"/>
Nit: use modifiers="meta" like we do for the alternate close key.

Comment 3

8 years ago
This ? key doesn't work with a German keyboard under Linux; I need to test this with my German Mac keyboard.

Comment 4

8 years ago
(In reply to comment #3)
> This ? key doesn't work with a German keyboard under Linux

Forget this, it does.

Updated

8 years ago
Attachment #394713 - Flags: review?(mnyromyr) → review+
(Assignee)

Comment 5

8 years ago
Landed with "meta": http://hg.mozilla.org/comm-central/rev/6c93daf47447
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.