Last Comment Bug 510773 - Help Keys [cmd+?] for mac does not work in the pageInfo window
: Help Keys [cmd+?] for mac does not work in the pageInfo window
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: Page Info (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: seamonkey2.0b2
Assigned To: Stefan [:stefanh]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-08-16 05:47 PDT by Stefan [:stefanh]
Modified: 2009-08-20 10:35 PDT (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Add key combo (2.01 KB, patch)
2009-08-16 05:52 PDT, Stefan [:stefanh]
mnyromyr: review+
neil: superreview+
Details | Diff | Splinter Review

Description Stefan [:stefanh] 2009-08-16 05:47:49 PDT
While we have F1, we don't have the Cmd+? combo that mac users expect.
Comment 1 Stefan [:stefanh] 2009-08-16 05:52:02 PDT
Created attachment 394713 [details] [diff] [review]
Add key combo

Mac users have had F1 for years now, so I figured win/nix users can cope with Cmd+?.
Comment 2 neil@parkwaycc.co.uk 2009-08-16 05:59:08 PDT
Comment on attachment 394713 [details] [diff] [review]
Add key combo

>     <key keycode="VK_ESCAPE"                       command="cmd_close"/>
>     <key key="."                 modifiers="meta"  command="cmd_close"/>
>     <key keycode="VK_F1"                           command="cmd_help"/>
>+    <key key="&openHelpMac.key;" modifiers="accel" command="cmd_help"/>
Nit: use modifiers="meta" like we do for the alternate close key.
Comment 3 Karsten Düsterloh 2009-08-18 15:39:09 PDT
This ? key doesn't work with a German keyboard under Linux; I need to test this with my German Mac keyboard.
Comment 4 Karsten Düsterloh 2009-08-18 15:45:02 PDT
(In reply to comment #3)
> This ? key doesn't work with a German keyboard under Linux

Forget this, it does.
Comment 5 Stefan [:stefanh] 2009-08-20 10:35:28 PDT
Landed with "meta": http://hg.mozilla.org/comm-central/rev/6c93daf47447

Note You need to log in before you can comment on or make changes to this bug.