Closed Bug 510874 Opened 15 years ago Closed 15 years ago

Replace ZIP error codes with the NS_ERROR_ codes.

Categories

(Core :: Networking: JAR, defect)

Product:
Core
Component:
Networking: JAR
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Tracking Flags:
Tracking Status
status1.9.2 --- beta5-fixed

People

(Reporter: alfredkayser, Assigned: alfredkayser)

References

Details

Attachments

(1 file, 1 obsolete file)

V2: Updated to current trunk, ready for checkin
18.80 KB, patch
dietrich
: approval1.9.2+
Details | Diff | Splinter Review 
Now that STANDALONE is removed, we should also replace the ZIP_ specific error codes with the normal NS_ERROR codes.

This is plain code cleanup, removing 'zipfile.h',
and replacing ZIP_ERR_MEMORY with NS_ERROR_OUT_OF_MEMORY, etc...
Also remove:
Remove ZIP_Seek
Remove #define ZFILE_CREATE    PR_WRONLY | PR_CREATE_FILE

Both are not used.
Simple search and replace patch for code cleanup.
Attachment #398360 - Flags: review?(tglek)
Comment on attachment 398360 [details] [diff] [review]
V1: Replace the ZIP_ errorcodes with the NS_ errorcodes

jar module is starting to look like nice code.
Attachment #398360 - Flags: review?(tglek) → review+

        Attachment #398360 -
        Attachment is obsolete: true

    
  
Keywords: checkin-needed

    
  
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED

    
  
Status: RESOLVED → VERIFIED

    
  

        Attachment #404807 -
        Flags: approval1.9.2?

    
  
Depends on: 510844

    
    

    
  
Safe change, would like this in 192
Depends on: 510247
No longer depends on: 510844

    
    

    
  
Comment on attachment 404807 [details] [diff] [review]
V2: Updated to current trunk, ready for checkin

a=me per discussion w/ beltzner et al.

        Attachment #404807 -
        Flags: approval1.9.2? → approval1.9.2+

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: