510916 - Cannot see folder names when modifying a bookmark from the star icon

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Dave Townsend [:mossop] (PTO until Aug 21st)]

Attachment: screenshot

See the screenshot, the folder names in the list to select from don't display except when selected.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Regressed between the builds 090722 and 090723:

Pass: http://hg.mozilla.org/mozilla-central/rev/02f8bf10f441
Fail: http://hg.mozilla.org/mozilla-central/rev/684dadc0726e

Checkins: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=02f8bf10f441&tochange=684dadc0726e

If you need a finer grained range I could do a HG bisect.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I have removed "-moz-appearance: listbox;" for the tree with DOMi and after that it works well again. Clearly a regression from bug 483537.

Comment 4

[Marco Bonardo [:mak]]

range and culprit confirmed here.

Comment 5

[Dave Townsend [:mossop] (PTO until Aug 21st)]

Clearly blocks

Comment 6

[Marco Bonardo [:mak]]

Attachment: patch v1.0

the -moz-appearance: listbox change appers correct looking at other platforms, since the panel uses a personalized hud style, is should probably just drop the appearance.

Comment 7

[Dão Gottwald [:dao]]

Comment on attachment 395021 [details] [diff] [review]
patch v1.0

> #editBMPanel_folderTree treechildren::-moz-tree-twisty {
>-  -moz-appearance: none !important;
>+  -moz-appearance: none;
...
> }
> 
> #editBMPanel_folderTree treechildren::-moz-tree-twisty(open) {
>   -moz-appearance: none;

It seems that -moz-appearance: none; for #editBMPanel_folderTree treechildren::-moz-tree-twisty(open), (selected) and (selected, open) is redundant and can be removed. Also please insert ">" between #editBMPanel_folderTree and treechildren.

Comment 8

[Marco Bonardo [:mak]]

Attachment: patch v1.1

Comment 9

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/2f923de567bb

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a1pre) Gecko/20090820 Minefield/3.7a1pre ID:20090820030630

Comment 12

[Marco Bonardo [:mak]]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/467d89df3cb5

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a2pre) Gecko/20090823 Namoroka/3.6a2pre ID:20090823033810