510917 - Downloading a .cab file from nightly builds page shows nothing in downloads manager

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aakash Desai [:aakashd]]

Steps to Reproduce:
Build Id: Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.2a1pre)
Gecko/20090817 Fennec/1.0a3pre (HTC Touch Pro)

1. Go to the mobile nightly builds page
2. Start a download on the latest .cab file
3. Click on "Save"
4. Go to the download manager while the download is running

Actual Results:
Nothing can be seen in the download manager.

Expected Results: 
The actively running download should be shown in the download manager just like on the latest maemo build.

Comment 2

[Aakash Desai [:aakashd]]

yep, this identifies the same behavior as bug 506491

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

I tried this today with the nightly 1.9.2 build 20090903 on my htc touch pro and the save button and open buttons do nothing.

Comment 4

[Stuart Parmenter]

Does any kind of saving work from anywhere?  We really need to get this fixed -- makes it difficult to download new versions of Fennec from Fennec ;)

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: WIP patch

looks like some code was copied and pasted from toolkit without being tested.  changing wildCardExt  => wildCardExtension and this.mLauncher => aLauncher gets the folder picker to pop up.  Clicking save and/or cancel on it doesn't do anything though...

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/mobile-browser/rev/a90a7411175a

Comment 8

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (Windows; U; Window3sCE 5.2; en-US; rv:1.9.2b5pre) Gecko/20091201 Namoroka/3.6b5pre Fennec/1.0a4pre

...but I am seeing the system save as dialog show up on the screen after clicking on "save". I'm filing this on bug 523125 to track this issue.

Comment 10

[Aakash Desai [:aakashd]]

Whoops, we have a testcase, 7092, already regression testing this bug.