51102 - [L12y] Please convert HTML files in wallet to XUL & DTD

Status: RESOLVED FIXED

(SeaMonkey :: General, defect, P3)

Description

[tao]

As of now, there are a few html files in chrome://communicator/locale/wallet/.

Please convert them into XUL & DTD to facilitate localization work.

thx

Comment 1

[msanz]

adding localizability keyword

Comment 2

[Stephen P. Morse]

I have obsoleted wallet's interview.html file by writing a new dialog 
(WalletViewer) completely xul.  That new dialog is contained in the following 
files, all in extensions/wallet/editor:

   WalletAddress.xul
   WalletBilling.xul
   WalletConcatenated.xul
   WalletCredit.xul
   WalletEmploy.xul
   WalletMisc.xul
   WalletName.xul
   WalletOther.xul
   WalletPhone.xul
   WalletPrimary.xul
   WalletShipping.xul
   WalletTree.xul
   WalletUrlspecific.xul
   WalletViewer.xul
   WalletViewer.js
   WalletViewer.dtd

The above files were checked in but are not yet part of the build.  The 
following patch will make them part of the build and will remove interview.html 
from the build.  This patch also obsoletes WalletEditor.xul as well -- the 
WalletViewer dialog performs all the functions of both interview.html and 
WalletEditor.xul.

Comment 3

[Stephen P. Morse]

Attachment: Patch to obsolete interview.html and replace it with WalletViewer.xul

Comment 4

[Stephen P. Morse]

Attachment: Slight modification to tasksOverlay.js patch per reviewers comment

Comment 5

[timeless]

/cvsroot/mozilla/extensions/wallet/editor/index.html
oncommand if it works instead of onclick.
i don't think we need to maintain manifest (jar.mn has replaced it)

Comment 6

[Samir Gehani]

Per second patch, r=sgehani for build changes to swap out interview.html
replacing it with the cited xul and dtd files.

Comment 7

[Stephen P. Morse]

timeless, nope oncommand doesn't work.  I just tried it.

I didn't realize that the jar files replaced the mac manifest files.  In any 
case, it's certainly safe to update the manifest files as long as they still 
exist in the codebase -- otherwise I'll get a comment from the reviewer who will 
search the codebase for interview.html and wonder why I didn't remove it from 
the manifest files.

Comment 8

[Karl Ove Hufthammer]

> I have obsoleted wallet's interview.html file by writing
> a new dialog (WalletViewer) completely xul.

Thank you very much. This is very important/nice for localizers. Translating
HTML files is a pain ...

Comment 9

[Stephen P. Morse]

*** Bug 49861 has been marked as a duplicate of this bug. ***

Comment 10

[Stephen P. Morse]

Message received from [e-mail] at Tue, 12 Dec 2000 16:12:24 -0800:

I am getting out of the business of super reviews, but I will grant you my last
one :-).  I looked this over and asked andreww to look at it as well.  

a=hangas

Comment 11

[Stephen P. Morse]

Fix checked in.