511159 - get unit tests running on Win32 PGO builds again

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[(not currently active) Ted Mielczarek]

On the 1.9.0 tree we have a Win32 PGO unittest builder. When we switched to our buildbot+hg infrastructure, we didn't bring that along, so it's a gap in our testing coverage. I think this is most easily fixed by fixing bug 486783 at this point, since if we run unit tests on the Win32 nightly builds, we're running them on PGO builds by definition. AIUI, that bug is a Q3 RelEng goal as well, so this shouldn't be adding any actual work to your plate, just tracking a regression from our 1.9.0 tree.

Comment 1

[Armen [:armenzg]]

As per conversation with ted, it will be fixed as soon as bug 486783 is fixed without having to do anything to be done.

Nightly builds are PGO + we add unittest to nightly builds -> we fix this bug

The reason to file is to keep track that this is a regression

Comment 2

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

Not sure I follow why keeping separate bug, but Lukas is working on all the other bugs about running unittests on nightly/debug/release builds.

Comment 3

[Mike Shaver (:shaver emeritus)]

We have a separate bug because this is a regression from coverage we had before, and many of us want that fixed regardless of what happens with the run-unit-tests-on-such-builds grander plan.

When should we expect to have the specific issue (subset of the other bug) resolved?  It affects when we can land some performance patches for Places.

Comment 4

[Lukas Blakk [:lsblakk] use ?needinfo]

Catlee is working on all the other bugs about running unittests on nightly/debug/release builds so I'm passing this one on too.

Comment 5

[(not currently active) Ted Mielczarek]

These are running now, despite the dep bug still being open:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1253898484.1253900127.6607.gz
(and green, to boot)

Comment 6

[Dietrich Ayala (:dietrich)]

(In reply to comment #5)
> These are running now, despite the dep bug still being open:
> http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1253898484.1253900127.6607.gz
> (and green, to boot)

can this bug be closed now?