51117 - Crash after patching a text file (Win and Linux)

Status: RESOLVED INCOMPLETE

(Core Graveyard :: Installer: XPInstall Engine, defect)

Description

[Jimmy Lee]

Build: 2000-09-01-08-M18(LINUX)

1. From http://jimbob/trigger3.html, click Acceptance drop-down and choose
   a_addwinpatch
2. Click Trigger case button
3. Click Install button to install text file
4. From http://jimbob/trigger3.html, click Acceptance drop-down and choose
   a_winpatch
5. Click Trigger case button
6. Click Install button to patch text file

RESULT:
File is patched.  Application crashes.

EXPECTED RESULT:
No crash.

Talkback Incident ID = 16715722

Stack Trace:
libpthread.so.0 + 0x5809 (0x401a3809) 
libc.so.6 + 0x584f9 (0x402914f9) 
libnspr4.so + 0x10eb0 (0x40180eb0) 
nsMemoryImpl::Free() 
nsMemory::Free() 
nsXPIDLCString::~nsXPIDLCString() 
nsLocalFile::~nsLocalFile() 
nsLocalFile::Release() 
nsCOMPtr_base::~nsCOMPtr_base() 
nsInstallPatch::~nsInstallPatch() 
nsInstall::CleanUp() 
nsInstall::FinalizeInstall() 
InstallFinalizeInstall() 
libmozjs.so + 0x2adc9 (0x4011adc9) 
libmozjs.so + 0x31a12 (0x40121a12) 
libmozjs.so + 0x2b189 (0x4011b189) 
libmozjs.so + 0x11d77 (0x40101d77) 
libmozjs.so + 0x11d20 (0x40101d20) 
libmozjs.so + 0x11c76 (0x40101c76) 
RunInstallOnThread() 
libnspr4.so + 0x1f4ae (0x4018f4ae) 
libpthread.so.0 + 0x4ce9 (0x401a2ce9)

EXPECTED RESULT:

Comment 1

[Jimmy Lee]

Adding keywords pp and crash.

Comment 2

[Jimmy Lee]

Nominating for nsbeta3.  I think this is lower impact, but unfortunately a high 
severity.  This used to work from Bug 37135.  The test is a simple use of the 
patch API.  Everybody will crash if he/she attempts to patch any text file on 
Linux. :-(

Comment 3

[Jimmy Lee]

Build: 2000-10-11-09-MN6(WIN)

We now have the same crash on both Win NT and 98.  Indicating platforms from 
Summary.

Incident ID = 18929028

Stack Trace:
0x0fa8c5a2 
InstallFinalizeInstall 
[d:\builds\seamonkey\mozilla\xpinstall\src\nsJSInstall.cpp, line 939] 
js_Invoke [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 822] 
js_Interpret [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 2621] 
js_Execute [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 994] 
JS_EvaluateUCScriptForPrincipals [d:\builds\seamonkey\mozilla\js\src\jsapi.c, 
line 3148] 
JS_EvaluateUCScript [d:\builds\seamonkey\mozilla\js\src\jsapi.c, line 3129] 
JS_EvaluateScript [d:\builds\seamonkey\mozilla\js\src\jsapi.c, line 3096] 
RunInstallOnThread 
[d:\builds\seamonkey\mozilla\xpinstall\src\nsSoftwareUpdateRun.cpp, line 431] 
_PR_NativeRunThread [pruthr.c, line 421] 
MSVCRT.dll + 0x3820 (0x78003820) 
KERNEL32.dll + 0x4ede (0x77f04ede)

Comment 4

[Daniel Veditz [:dveditz]]

We want patching to work

Comment 5

[Daniel Veditz [:dveditz]]

Moz 0.9 tasks

Comment 6

[dprice (gone)]

I will adopt this one.

Comment 7

[Daniel Veditz [:dveditz]]

I wouldn't have thought this one was a high priority and I'd recommend against
it. Patching has an entire toolset which will be a waste to learn if fixing
*all* the patching bugs is not a priority.

Comment 8

[Jimmy Lee]

Syd, I think this should be nsbranch-.  I agree with Dan.

Comment 9

[Jaime Rodriguez, Jr.]

Syd - People think this one should be minused. Pls do so, if you agree, so we
can get rid of some of the noise.

Comment 10

[chris hofmann]

nsbranch-

Comment 11

[Syd Logan]

Resetting milestone of all nsbeta1-bugs, only nsbeta1+ bugs should have a target
milestone.

Comment 12

[Syd Logan]

Resetting milestone, only nsbeta1+ bugs can have a milestone on them, these are
niminated, but not yet plussed.

Comment 13

[Kevin Berkheiser]

The links in this bug are no longer valid.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7b) Gecko/20040316

Comment 14

[Andrew Schultz]

the URLs were behind the NS firewall...

Comment 15

[Wayne Mery (:wsmwk)]

no testcase
=> incomplete