Last Comment Bug 511216 - Assignee is blank in Whine emails
: Assignee is blank in Whine emails
Status: RESOLVED FIXED
:
Product: Bugzilla
Classification: Server Software
Component: Whining (show other bugs)
: unspecified
: All All
: P1 normal (vote)
: Bugzilla 3.4
Assigned To: Kent Rogers [:mrbball]
: default-qa
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-08-18 13:55 PDT by reid
Modified: 2010-02-28 10:43 PST (History)
4 users (show)
LpSolit: approval+
LpSolit: blocking3.6+
LpSolit: approval3.4+
mkanat: blocking3.4.5+
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Sample whine e-mail demonstrating the missing value (24.59 KB, message/rfc822)
2009-08-18 13:56 PDT, reid
no flags Details
patch against 3.4.1 using assignee real name in the mails (2.45 KB, patch)
2009-08-18 14:03 PDT, reid
LpSolit: review-
Details | Diff | Splinter Review
V2 - patch against tip, keeping assignee login name in the whine email (2.51 KB, patch)
2009-10-22 09:13 PDT, Kent Rogers [:mrbball]
no flags Details | Diff | Splinter Review
patch for 3.6, v2.1 (3.22 KB, patch)
2009-12-27 16:38 PST, Frédéric Buclin
LpSolit: review+
Details | Diff | Splinter Review
patch for 3.4, v2 (3.00 KB, patch)
2009-12-27 16:51 PST, Frédéric Buclin
LpSolit: review+
Details | Diff | Splinter Review

Description reid 2009-08-18 13:55:43 PDT
User-Agent:       Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.0.10) Gecko/2009042315 Firefox/3.0.10
Build Identifier: 3.4.1

In my whine mails, the value of the Assignee field is missing.

Reproducible: Always
Comment 1 reid 2009-08-18 13:56:29 PDT
Created attachment 395137 [details]
Sample whine e-mail demonstrating the missing value
Comment 2 reid 2009-08-18 14:03:12 PDT
Created attachment 395140 [details] [diff] [review]
patch against 3.4.1 using assignee real name in the mails

This patch uses the assignee real name for the whine mails.

It is against 3.4.1. I realize that that's not the right way to submit a patch, but I don't yet have a HEAD install and thought that since it's so small, it would be useful anyway. A cursory glance at HEAD makes me think that it would probably apply OK.

Feedback appreciated.
Comment 3 Kent Rogers [:mrbball] 2009-10-22 09:13:13 PDT
Created attachment 407776 [details] [diff] [review]
V2 - patch against tip, keeping assignee login name in the whine email

I just had this problem reported on my 3.4.1 installation.  

I see that the issue is that "map_assigned_to.login_name" now gets
mapped back to "assigned_to" by Search.pm::COLUMNS(), when the
select column list is built at line 927 (in Search.pm::init()).
Thus, that is the name that is used to build the "bug" arrays in
whine.pl::run_queries(), and ultimately the name that must be used
in the whine/mail.* templates.

This patch is against the tip and leaves login_name in the whine emails.

BTW, this is a bug, not an enhancement.  Assignee was there in 3.2.4
whine emails but is missing in 3.4.1 whine emails.
Comment 4 Max Kanat-Alexander 2009-11-19 15:40:14 PST
By the way, the reason that this bug was not given the appropriate priority before was that the summary described a solution, not a problem. Usually enhancements describe a solution, and bugs describe a problem.
Comment 5 reid 2009-11-19 15:50:06 PST
Max, my original summary was "Assignee value missing from whine mails" which seems quite similar to me to the current "Assignee is blank in Whine emails"... I don't understand how that describes a solution rather than a problem. Can you give any guidance on what I'm missing?
Comment 6 Max Kanat-Alexander 2009-11-19 16:02:12 PST
(In reply to comment #5)
> Max, my original summary was "Assignee value missing from whine mails" which
> seems quite similar to me to the current "Assignee is blank in Whine emails"...
> I don't understand how that describes a solution rather than a problem. Can you
> give any guidance on what I'm missing?

  Oh, you're indeed right, and I simply made an error here when I changed the field values. :-)
Comment 7 Frédéric Buclin 2009-12-27 16:38:13 PST
Created attachment 419265 [details] [diff] [review]
patch for 3.6, v2.1

Unbitrotten patch, due to bug 519142. I also removed the duplicated 'assigned_to' entry in whine.pl.
Comment 8 Frédéric Buclin 2009-12-27 16:43:41 PST
Comment on attachment 395140 [details] [diff] [review]
patch against 3.4.1 using assignee real name in the mails

>-  Assignee: [%+ bug.$assignee_login_string %]
>+  Assignee: [%+ bug.assigned_to_realname %]

No reason to display the real name of assignees. We should keep login names.
Comment 9 Frédéric Buclin 2009-12-27 16:51:06 PST
Created attachment 419266 [details] [diff] [review]
patch for 3.4, v2

Backport of the patch for 3.6.
Comment 10 Frédéric Buclin 2009-12-27 16:52:13 PST
Leaving Kent as the assignee as I simply removed bitrot.
Comment 11 Frédéric Buclin 2009-12-27 17:01:12 PST
tip:

Checking in whine.pl;
/cvsroot/mozilla/webtools/bugzilla/whine.pl,v  <--  whine.pl
new revision: 1.41; previous revision: 1.40
done
Checking in template/en/default/whine/mail.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/whine/mail.html.tmpl,v  <--  mail.html.tmpl
new revision: 1.10; previous revision: 1.9
done
Checking in template/en/default/whine/mail.txt.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/whine/mail.txt.tmpl,v  <--  mail.txt.tmpl
new revision: 1.10; previous revision: 1.9
done


3.4.4:

Checking in whine.pl;
/cvsroot/mozilla/webtools/bugzilla/whine.pl,v  <--  whine.pl
new revision: 1.38.2.2; previous revision: 1.38.2.1
done
Checking in template/en/default/whine/mail.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/whine/mail.html.tmpl,v  <--  mail.html.tmpl
new revision: 1.7.4.1; previous revision: 1.7
done
Checking in template/en/default/whine/mail.txt.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/whine/mail.txt.tmpl,v  <--  mail.txt.tmpl
new revision: 1.7.4.1; previous revision: 1.7
done

Note You need to log in before you can comment on or make changes to this bug.