511290 - Can't use standard file picker to upload files from user's Maemo File area

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[cmtalbert]

Attachment: simple file picker to try out the bug

1. Find an <input type="file"> tag somewhere on the net, or just use the one in the attachment.
2. Try to point the upload at a file in your Maemo Documents folder (/home/user/MyDocs/.documents).

= Expected =
You'd expect the firefox uploader to look a lot more like the maemo file manager which does a decent job of hiding the complexity of the underlying linux system and presents the user with a "user area" of files.

= Actual =
The firefox file picker just opens right up to show you /  and you have no way to get to those items in your "maemo user area" because they are all hidden directories beneath /home/user/MyDocs and the file picker doesn't show hidden directories.

Comment 1

[cmtalbert]

I think this should both be in the litmus testcases (if it isn't already) and it should block fennec 1.0.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

romaxa - does microb have some code we could add to mozilla?

Comment 3

[Stuart Parmenter]

does this involve using the hildon file picker rather than the gtk one?

Comment 4

[Antonio Gomes (tonikitoo)]

i am afraid microb's ui still implements its own file picker (not opensource), and iirc not even shared w/ other system apps...

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

ran across this in the smoketests for the n810 tonight while testing 20090928 1.9.2 beta4 candidate.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

The Chinook SDK does not have a Hildon File Chooser dialog. The Diablo SDK does have a File Chooser.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Hmm, I guess it is in Chinook, just not in my SDK. Looks like I need to install libhildonfm2 to get the header for the File Chooser.

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

Installed the package like so:

fakeroot apt-get install libhildonfm2-dev

Working on a patch now

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

This patch adds support for the native Hildon file picker dialog. The Hildon dialog is based on the Gtk dialog, so nearly all of the existing API calls work for Hildon too.

The patch adds the right includes, Hildon specific creation call and response handling.

The Hildon dialog has a fixed set of buttons, but the accept caption can be changed. Since the button is really the GTK_RESPONSE_OK, I needed to add that response to the switch statement.

This patch will require anyone building for Maemo to update their scratchbox:
fakeroot apt-get install libhildonfm2-dev

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 403791 [details] [diff] [review]
patch

Adding Ted for the build parts

Comment 11

[(not currently active) Ted Mielczarek]

(In reply to comment #9)
> This patch will require anyone building for Maemo to update their scratchbox:
> fakeroot apt-get install libhildonfm2-dev

Is this already done on the Linux build slaves? If not, file a RelEng bug about it and make it block this one.

Comment 12

[Mark Finkle (:mfinkle) (use needinfo?)]

filed bug 520562

Comment 13

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed to m-c:
http://hg.mozilla.org/mozilla-central/rev/7c0b5c2b3501

Comment 14

[Mark Finkle (:mfinkle) (use needinfo?)]

burned the tree

Comment 15

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch 2 (configure.in fix)

This is the same exact patch as before except for a simple 2 line change in configure.in:

was:

+PKG_CHECK_MODULES(LIBHILDONFM,hildon-fm-2)
+AC_SUBST(LIBHILDONFM_CFLAGS)
+AC_SUBST(LIBHILDONFM_LIBS)

now:

+PKG_CHECK_MODULES(LIBHILDONFM,hildon-fm-2,
+                  NS_HILDONFM=1,
+                  NS_HILDONFM)
+AC_SUBST(LIBHILDONFM_CFLAGS)
+AC_SUBST(LIBHILDONFM_LIBS)

This passes on the try servers

Comment 16

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed m-c:
http://hg.mozilla.org/mozilla-central/rev/b24cd9a1161b

Comment 17

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 406161 [details] [diff] [review]
patch 2 (configure.in fix)

Needed for Fennec 1.0

Comment 18

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 406161 [details] [diff] [review]
patch 2 (configure.in fix)

a192=beltzner

Comment 19

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed m-192:
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/dd32cccef96a