Closed
Bug 511307
Opened 13 years ago
Closed 13 years ago
TM: some Math functions aren't specialized for integers
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
status1.9.2 | --- | beta1-fixed |
People
(Reporter: dvander, Assigned: gal)
References
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file, 2 obsolete files)
9.83 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
This is hurting recursion for access-binary-trees, since an inner recursive tree needs to be thrown away when an outer loop passes a variable flowing from Math.max().
![]() |
Reporter | |
Updated•13 years ago
|
Blocks: tracerecursion
Assignee | ||
Updated•13 years ago
|
Assignee: general → gal
Assignee | ||
Comment 1•13 years ago
|
||
Assignee | ||
Updated•13 years ago
|
Summary: TM: Math.max/Math.min aren't specialized for integers → TM: some Math functions aren't specialized for integers
Assignee | ||
Comment 2•13 years ago
|
||
Attachment #395212 -
Attachment is obsolete: true
Assignee | ||
Updated•13 years ago
|
Attachment #395219 -
Flags: review?(dvander)
Assignee | ||
Comment 3•13 years ago
|
||
Attachment #395219 -
Attachment is obsolete: true
Attachment #395219 -
Flags: review?(dvander)
Assignee | ||
Updated•13 years ago
|
Attachment #395246 -
Flags: review?(shaver)
Assignee | ||
Updated•13 years ago
|
Attachment #395246 -
Attachment is obsolete: true
Attachment #395246 -
Flags: review?(shaver)
Assignee | ||
Updated•13 years ago
|
Attachment #395219 -
Attachment is obsolete: false
Attachment #395219 -
Flags: review?(dvander)
![]() |
Reporter | |
Updated•13 years ago
|
Attachment #395219 -
Flags: review?(dvander) → review+
![]() |
Reporter | |
Comment 4•13 years ago
|
||
Comment on attachment 395219 [details] [diff] [review] patch Works great. No more multitrees nastiness on access-binary trees.
Assignee | ||
Comment 5•13 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/ccf91ba2d62a
Whiteboard: fixed-in-tracemonkey
Assignee | ||
Comment 6•13 years ago
|
||
This broke builds with JIT off. Fixing on the fly. http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1250721307.1250721987.4827.gz
Assignee | ||
Comment 7•13 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/15166116171f
Comment 8•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/ccf91ba2d62a
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 9•13 years ago
|
||
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/1df2480e789d
status1.9.2:
--- → beta1-fixed
Flags: wanted1.9.2+
You need to log in
before you can comment on or make changes to this bug.
Description
•