Closed Bug 511307 Opened 12 years ago Closed 12 years ago

TM: some Math functions aren't specialized for integers

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
status1.9.2 --- beta1-fixed

People

(Reporter: dvander, Assigned: gal)

References

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file, 2 obsolete files)

patch
9.83 KB, patch
dvander
: review+
Details | Diff | Splinter Review 
This is hurting recursion for access-binary-trees, since an inner recursive tree needs to be thrown away when an outer loop passes a variable flowing from Math.max().
Assignee: general → gal
Attached patch patch (obsolete) — — Splinter Review
Summary: TM: Math.max/Math.min aren't specialized for integers → TM: some Math functions aren't specialized for integers
Attached patch patch — — Splinter Review
Attachment #395212 - Attachment is obsolete: true
Attachment #395219 - Flags: review?(dvander)
Attachment #395219 - Attachment is obsolete: true
Attachment #395219 - Flags: review?(dvander)
Attachment #395246 - Flags: review?(shaver)
Attachment #395246 - Attachment is obsolete: true
Attachment #395246 - Flags: review?(shaver)
Attachment #395219 - Attachment is obsolete: false
Attachment #395219 - Flags: review?(dvander)
Attachment #395219 - Flags: review?(dvander) → review+
Comment on attachment 395219 [details] [diff] [review]
patch

Works great. No more multitrees nastiness on access-binary trees.
http://hg.mozilla.org/tracemonkey/rev/ccf91ba2d62a
Whiteboard: fixed-in-tracemonkey
This broke builds with JIT off. Fixing on the fly.

http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1250721307.1250721987.4827.gz
http://hg.mozilla.org/mozilla-central/rev/ccf91ba2d62a
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Depends on: 620532
You need to log in before you can comment on or make changes to this bug.