511333 - @font-face { src: local() } parsing doesn't match ()'s properly on error

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P4)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

While reviewing bug 511304 I noticed that there were some missing SkipUntil calls in the parsing of local(); in other words, the parser wasn't doing proper parenthesis matching after hitting parsing errors.

I should have noticed this while reviewing bug 441469, but didn't.

Comment 1

[Zack Weinberg (:zwol)]

Comment on attachment 395256 [details] [diff] [review]
patch

r=zweinberg

Comment 2

[Zack Weinberg (:zwol)]

Attachment: patch part 2

Additional patch adding the necessary SkipUntil calls to ParseFontSrcFormat.

Comment 3

[Zack Weinberg (:zwol)]

By way of explanation: while reviewing dbaron's patch I realized the same bug existed in the format() parser, and he asked me on IRC to do an additional patch rather than letting him revise.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 395404 [details] [diff] [review]
patch part 2

r=dbaron

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I'll land this later today.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://hg.mozilla.org/mozilla-central/rev/ecca9c36a3b9
http://hg.mozilla.org/mozilla-central/rev/b36521d220ff