Closed Bug 511333 Opened 15 years ago Closed 15 years ago

@font-face { src: local() } parsing doesn't match ()'s properly on error

Categories

(Core :: CSS Parsing and Computation, defect, P4)

defect

Tracking

()

RESOLVED FIXED
mozilla1.9.3a1

People

(Reporter: dbaron, Unassigned)

References

Details

(Keywords: css2, css3)

Attachments

(2 files)

Attached patch patchSplinter Review
While reviewing bug 511304 I noticed that there were some missing SkipUntil calls in the parsing of local(); in other words, the parser wasn't doing proper parenthesis matching after hitting parsing errors.

I should have noticed this while reviewing bug 441469, but didn't.
Attachment #395256 - Flags: review?(zweinberg)
Attachment #395256 - Flags: review?(zweinberg) → review+
Comment on attachment 395256 [details] [diff] [review]
patch

r=zweinberg
Attached patch patch part 2Splinter Review
Additional patch adding the necessary SkipUntil calls to ParseFontSrcFormat.
Attachment #395404 - Flags: review?(dbaron)
By way of explanation: while reviewing dbaron's patch I realized the same bug existed in the format() parser, and he asked me on IRC to do an additional patch rather than letting him revise.
Comment on attachment 395404 [details] [diff] [review]
patch part 2

r=dbaron
Attachment #395404 - Flags: review?(dbaron) → review+
I'll land this later today.
http://hg.mozilla.org/mozilla-central/rev/ecca9c36a3b9
http://hg.mozilla.org/mozilla-central/rev/b36521d220ff
Status: NEW → RESOLVED
Closed: 15 years ago
Priority: -- → P4
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
You need to log in before you can comment on or make changes to this bug.