@font-face { src: local() } parsing doesn't match ()'s properly on error

RESOLVED FIXED in mozilla1.9.3a1

Status

()

P4
normal
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: dbaron, Unassigned)

Tracking

({css2, css3})

Trunk
mozilla1.9.3a1
css2, css3
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Created attachment 395256 [details] [diff] [review]
patch

While reviewing bug 511304 I noticed that there were some missing SkipUntil calls in the parsing of local(); in other words, the parser wasn't doing proper parenthesis matching after hitting parsing errors.

I should have noticed this while reviewing bug 441469, but didn't.
Attachment #395256 - Flags: review?(zweinberg)
Attachment #395256 - Flags: review?(zweinberg) → review+
Comment on attachment 395256 [details] [diff] [review]
patch

r=zweinberg
Created attachment 395404 [details] [diff] [review]
patch part 2

Additional patch adding the necessary SkipUntil calls to ParseFontSrcFormat.
Attachment #395404 - Flags: review?(dbaron)
By way of explanation: while reviewing dbaron's patch I realized the same bug existed in the format() parser, and he asked me on IRC to do an additional patch rather than letting him revise.
You need to log in before you can comment on or make changes to this bug.